Speed up incremental build #1682
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasgoergens
changed the title
matthiasgoergens
force-pushed
the
matthias/speed-up-cli-compiling
branch
from
ef99615
to
0caf013
Compare
matthiasgoergens
commented
May 9, 2024
| @@ -0,0 +1,47 @@ | |||
| pub mod nop; | |||
There was a problem hiding this comment.
This file moved here from the CLI.
matthiasgoergens
commented
May 9, 2024
circuits/tests/riscv_tests.rs
Outdated
| @@ -44,10 +44,9 @@ macro_rules! test_elf { | |||
| ($test_name:ident, $file_name:tt) => { | |||
| #[test] | |||
| fn $test_name() -> Result<()> { | |||
| run_test(include_bytes!(concat!( | |||
There was a problem hiding this comment.
Need to check whether reading the files at runtime actually improves build speed.
matthiasgoergens
commented
May 9, 2024
| @@ -56,6 +57,7 @@ plonky2_crypto = { git = "https://github.com/0xmozak/plonky2-crypto.git" } | |||
| criterion = { version = "0.5", default-features = false, features = ["html_reports", "plotters", "cargo_bench_support"] } | |||
|
|
|||
| [patch.crates-io] | |||
| clio = { git = "https://github.com/0xmozak/clio.git" } | |||
There was a problem hiding this comment.
This change can go into its own PR.
eightfilms
reviewed
May 9, 2024
There was a problem hiding this comment.
I'm all for improving compilation speed but seems like this comes at the cost of reordering our CLI logic in a somewhat confusing manner, I'm not sure if args should belong outside of the cli.
eightfilms
reviewed
May 9, 2024
circuits/tests/riscv_tests.rs
Outdated
| let elf = fs::read(concat!("riscv-testdata/testdata/", $file_name)) | ||
| .expect("Should have been able to read the file"); | ||
| run_test(&elf) | ||
| run_test(include_bytes!(concat!( |
There was a problem hiding this comment.
This probably adds compile time. rust-lang/rust#65818
matthiasgoergens
added a commit
that referenced
this pull request
May 9, 2024
Upgrade clio and remove a now-obsolete linter exception Extracted from #1682
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shuffle our code around a bit to speed up the incremental build.
Our target here is to make
time cargo test --no-runrun faster after a small change tocircuits.At the moment on my machine this PR speeds that benchmark up from around 35s on
maindown to around15s.