Add CI job for checking if our WASM compilation succeeds #1186
Conversation
|
May need something like livepeer/catalyst#811 |
jakzale
force-pushed
the
jakub/playwright
branch
from
5f911d0
to
9cdc839
Compare
Add tests for both wasm32-unknown-unknown and wasm32-wasi
jakzale
force-pushed
the
jakub/playwright
branch
from
9cdc839
to
e72128a
Compare
jakzale
force-pushed
the
jakub/playwright
branch
from
9b9fa96
to
df63c0f
Compare
|
Can we make the tests pass? |
@matthiasgoergens, this is blocked by #1242. |
| with: | ||
| name: playwright-report | ||
| path: wasm-demo/playwright-report/ | ||
| retention-days: 30 |
There was a problem hiding this comment.
So this test suite is intended to be triggered only on push to main branch, since its slow. The slowness comes from
- need to install playwright
- The test
test-slowwhich runs test on multiple browsers
👍
| @@ -2,3 +2,4 @@ | |||
| channel = "nightly-2024-01-23" | |||
| components = ["rustfmt", "rust-src", "rust-analyzer", "clippy"] | |||
| profile = "minimal" | |||
| targets = ["wasm32-unknown-unknown", "wasm32-wasi"] | |||
There was a problem hiding this comment.
wasm32-wasi target has been added to access OS services, since previously we had issues with, for example obtaining time.
There was a problem hiding this comment.
We also use wasm32-wasi to able to quickly test our WASM build by running it with wasmtime. Also, wasm32-wasi tends to give more meaningful stack traces in case of an exception.
| "test": "wasmtime ./dist/demo.wasm", | ||
| "test-slow": "playwright test" | ||
| } | ||
| } |
There was a problem hiding this comment.
So this runs
wasm-packto generate .js files which run the wasm code.cargo buildto generate target forwasm32-wasiwebpackto bundle stuff generated bywasm-packintopkg/wasm_demo.js
test is for testing the wasm32-wasi target through wasmtime as runtime environment
test-slow actually automates human interaction through browser where he would execute commands to run the wasm targets. It checks both targets on three major browsers.
| await page.getByText("Loading wasm32-wasi version of demo...").waitFor(); | ||
| await page.getByText("Proving :true").waitFor(); | ||
| await page.getByText("wasm32-wasi demo completed.").waitFor(); | ||
| }); |
There was a problem hiding this comment.
Simulating human interaction 👍
| // For some reason this is incompatible | ||
| wasi.start(inst as any); | ||
|
|
||
| term.writeln("wasm32-wasi demo completed."); |
There was a problem hiding this comment.
Runs wasm32-wasi target on browser.
| wasm_demo(99, 99); | ||
|
|
||
| term.writeln("wasm32-unknown-unknown demo completed."); | ||
| }); |
There was a problem hiding this comment.
runs wasm_demo generated through wasm-pack
|
This is probably blocked by #1270, so we can have |
|
@matthiasgoergens @codeblooded1729, I can try splitting this PR into smaller ones. Would that help? |
|
@jakzale What's the status of this? |
|
@matthiasgoergens, it ended up being too big to get it reviewed properly. I need to split it into smaller chunks, but I want to finish work on debugging first. |
This PR expands on our WASM demo by