Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove compiled JS from repo and integrate build step before publishin #92

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Remove compiled JS from repo and integrate build step before publishin #92

merged 3 commits into from
Oct 7, 2024

Conversation

Rahulagg13
Copy link
Contributor

@Rahulagg13 Rahulagg13 commented Oct 7, 2024

Description

This PR removes the compiled JavaScript files (dist/) from the repository and automates the build process during the publishing workflow. The following changes were made:

  • Added dist/ to .gitignore to exclude compiled files from version control.
  • Added a clean script to remove the dist/ directory before building.
  • Updated the prepublishOnly script to clean and rebuild the project before publishing.
  • Ensured that the build step runs automatically before publishing with Yarn.

Benefits

  • Repository Cleanliness: The repository will only contain source files, improving clarity and reducing clutter.
  • Automated Build Process: The correct build artifacts are generated at publish time, preventing stale or incorrect compiled code from being published.

Related Issue

Additional Notes

  • The project can now be published using Yarn with yarn publish, which automatically triggers the build step.

Copy link
Owner

@0xflotus 0xflotus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove also the dist directory

package.json Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Oct 7, 2024

@0xflotus 0xflotus merged commit 2393eb6 into 0xflotus:main Oct 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove compiled JS from repository
2 participants