Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oxidize prove_rpc.sh #796

Merged
merged 22 commits into from
Nov 21, 2024
Merged

Oxidize prove_rpc.sh #796

merged 22 commits into from
Nov 21, 2024

Conversation

sergerad
Copy link
Collaborator

@sergerad sergerad commented Nov 14, 2024 •
edited
Loading

  • Move outdated functionality to separate module
  • Add process module for constructing subprocesses run by xtasks
  • Update xtask to handle both outdated and prove-rpc commands
  • Implement prove_rpc.sh in rust module

Relates to #774

@sergerad
Copy link
Collaborator Author

Also relates to #794. @temaniarpit27 note this PR has a few changes to xtask.rs that the oxidized scripts will share.

@github-actions github-actions bot added crate: zero_bin Anything related to the zero-bin subcrates. ci labels Nov 16, 2024
@sergerad sergerad marked this pull request as ready for review November 19, 2024 07:38
0xaatif
0xaatif reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@0xaatif 0xaatif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going in the right direction :)

scripts/xtask.rs Show resolved Hide resolved
scripts/outdated.rs Show resolved Hide resolved
scripts/process.rs Outdated Show resolved Hide resolved
scripts/process.rs Outdated Show resolved Hide resolved
scripts/prove_rpc.rs Outdated Show resolved Hide resolved
scripts/prove_rpc.rs Outdated Show resolved Hide resolved
scripts/prove_rpc.rs Outdated Show resolved Hide resolved
scripts/prove_rpc.rs Show resolved Hide resolved
scripts/prove_rpc.rs Show resolved Hide resolved
scripts/prove_rpc.rs Outdated Show resolved Hide resolved
@sergerad sergerad force-pushed the serge/oxidize-prove-rpc branch from 33d1b52 to 598f3a1 Compare November 20, 2024 06:54
@sergerad sergerad force-pushed the serge/oxidize-prove-rpc branch from 38424ec to 831b68d Compare November 20, 2024 07:56
@sergerad sergerad requested a review from 0xaatif November 20, 2024 08:06
atanmarko
atanmarko approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@atanmarko atanmarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Some nits

scripts/prove_rpc.rs Show resolved Hide resolved
.github/workflows/jerigon-native.yml Outdated Show resolved Hide resolved
zero/README.md Outdated Show resolved Hide resolved
0xaatif
0xaatif approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@0xaatif 0xaatif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's wave this through

paulgoleary
paulgoleary approved these changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@paulgoleary paulgoleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atanmarko atanmarko merged commit c79ef67 into 0xPolygonZero:develop Nov 21, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atanmarko atanmarko atanmarko approved these changes

@0xaatif 0xaatif 0xaatif approved these changes

@paulgoleary paulgoleary paulgoleary approved these changes

@Nashtare Nashtare Awaiting requested review from Nashtare Nashtare is a code owner

Assignees
No one assigned
Labels
ci crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Zero EVM
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sergerad @paulgoleary @atanmarko @0xaatif