-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev: syntax highlighting for EVM Assembly #674
Conversation
Thanks Aatif, I just installed and tested the extension from #674, it does highlight the comments properly as expected! Ideally, the long term goal of such extension would be the common convenient features offered by others.
If you think these are doable (with or without parser refactoring), feel free to layout the iterative steps to achieve them in some tickets. The priority is definitely not as high as getting the cdk-erigon type2 up and running, but would still be really great to have. |
(I can also make individual tickets for each features with additional info on what could be expected, if it's easier to reason about them that way) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (just needs to pull latest develop
)
The only thing this really gives us is syntax highlighting for comments.
If we want more I think we should rewrite our parser.
See #299