Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LogicColumnsView struct for LogicStark #347

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

gio256
Copy link
Contributor

@gio256 gio256 commented Jul 1, 2024

Addresses #312 for the logic stark. A few questions:

  • Is there anything special needed for PRs that touch constraints (e.g. a version bump somewhere)?
  • Would it be beneficial to add some generate-evaluate tests similar to those in arithmetic::addcy?

@github-actions github-actions bot added the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label Jul 1, 2024
@Nashtare
Copy link
Collaborator

Nashtare commented Jul 1, 2024

Hey @gio256! Thank you again for this work. To answer your questions:

  • constraints change do indeed yield a MINOR increment. We do handle them before proceeding to new releases so you don't need to bother with it here.

  • tests similar to addcy would indeed be a great add-on if you could!

Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gio256! LGTM!

Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the added tests! LGTM!

@Nashtare Nashtare merged commit a591b6f into 0xPolygonZero:develop Jul 2, 2024
14 checks passed
@gio256 gio256 deleted the logic-cols branch July 2, 2024 14:18
@Nashtare Nashtare added this to the Type 1 - Q3 2024 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants