Add FFT-based specification for Poseidon MDS layer on x86 targets #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've also added a custom |
Nashtare
force-pushed
the
poseidon-native
branch
from
1ecff8b
to
492a805
Compare
|
@nbgl I saw you assigned yourself to it, so I just rebased it with latest main. |
Nashtare
force-pushed
the
poseidon-native
branch
from
492a805
to
bb2233c
Compare
|
Perfect! It looks good. Thank you for the contribution :) |
nbgl
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overrides the default MDS layer implementation of Poseidon on x86 targets to perform an FFT-based matrix-vector multiplication, similarly to what is done on aarch64 targets. Given that the x86_64-specific methods for Poseidon are all disabled, this can yield a significant speed-up on such targets, compared to the naive
mds_row_shfimplementation.On Ubuntu 22.04, Intel® Core™ i7-9750H CPU @ 2.60GHz × 12, I am getting a 30% speed-up when running the
hashingbenchmark.