feat: Pass original txn RLP encodings #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashtare
commented
Jun 11, 2024
| ) | ||
| }) | ||
| .collect(); | ||
| let storage_trie = HashedPartialTrie::try_from_iter( |
There was a problem hiding this comment.
This and below are due to the refactoring on latest mpt_trie versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser currently proceeds to a sanity check on the decoded transaction, as some tests have a different hardcoded RLP txn encoding than what we get when re-encoding the decoded txn (usually through a zero scalar encoded via
0x0000000000000000000000000000000000000000000000000000000000000000instead of0x).This is actually not problematic if we reuse this original encoding when generating the associated test
GenerationInputs(so that we can still verify the txn trie insertion matches with the final root). By only testing txn decoding and storing the initial encoded bytes from the test suite, we can parse successfully an additional 347 tests.