Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore failing tests from bad gas limit config #29

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

Nashtare
Copy link
Contributor

Not very important, but in the resulting test_pass_state CSV file from running the plonky2_runner, a lot of "Failed" results happen to arise from tests which we cannot verify because of the design choice of supporting only 32-bit gas limits.

As such, I'm proposing to have a dedicated TestPass variant called Ignored purposedly for this failure case, to trim the number of false negatives.

@Nashtare Nashtare force-pushed the ignored_tests branch 2 times, most recently from 280b23b to 65a918a Compare July 16, 2023 17:23
@Nashtare
Copy link
Contributor Author

For the record, I'm also running the whole suite against the latest main and the changes from this branch, to make sure those ignored tests wouldn't reveal some failing edge cases.

@BGluth
Copy link
Collaborator

BGluth commented Jul 17, 2023

Yeah this seems like a reasonable way to handle this. I think it might be slightly cleaner to filter these out in the parser instead when we parse the test *.json --> *.cbor, but this is more than fine. Thanks for adding this!

@BGluth BGluth merged commit f878759 into 0xPolygonZero:main Jul 17, 2023
@Nashtare Nashtare mentioned this pull request Jul 25, 2023
@Nashtare Nashtare deleted the ignored_tests branch August 30, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants