Ignore failing tests from bad gas limit config #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not very important, but in the resulting
test_pass_state
CSV file from running theplonky2_runner
, a lot of "Failed" results happen to arise from tests which we cannot verify because of the design choice of supporting only 32-bit gas limits.As such, I'm proposing to have a dedicated
TestPass
variant calledIgnored
purposedly for this failure case, to trim the number of false negatives.