Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use alloy instead of ethers and primitive_types #22

Closed
wants to merge 18 commits into from

Conversation

0xaatif
Copy link

@0xaatif 0xaatif commented May 15, 2024

Motivation

Outstanding questions

  • How do I test this?

Changes

  • title
  • mod compat for shimming until zk_evm#229
  • mod rlp for encoding alloy::rpc types
  • use let ... else instead of if let ... else panic!(...)
  • replace panic!("wtf?!") with useful messages
  • remove a bunch of unnecessary clones
  • cleaner fn main
  • make clippy slightly happier
  • refactor out some closures

@0xaatif 0xaatif changed the title refactor(eth-tx-proof): use alloy instead of ethers and primitive_types refactor: use alloy instead of ethers and primitive_types May 15, 2024
@0xaatif 0xaatif requested review from Nashtare and cpubot May 15, 2024 20:02
@0xaatif
Copy link
Author

0xaatif commented May 29, 2024

@0xaatif 0xaatif closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant