Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pid2274 support privado network #424

Merged
merged 5 commits into from
Jul 25, 2024

Conversation

plusema86
Copy link
Contributor

Added a field called method to the chain config object, this field specify which did method to use while creating the identity, if null the default one will be used by the core lib (currently polygonid)

@plusema86 plusema86 requested a review from 5eeman July 25, 2024 12:28
@plusema86 plusema86 self-assigned this Jul 25, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 35.71429% with 18 lines in your changes missing coverage. Please review.

Project coverage is 21.77%. Comparing base (3943670) to head (170a86f).
Report is 2 commits behind head on develop.

Files Patch % Lines
lib/identity/domain/entities/did_entity.dart 0.00% 5 Missing ⚠️
...ib/identity/domain/use_cases/get_did_use_case.dart 0.00% 3 Missing ⚠️
...omain/use_cases/fetch_onchain_claims_use_case.dart 0.00% 2 Missing ⚠️
...data_sources/lib_pidcore_identity_data_source.dart 0.00% 2 Missing ⚠️
lib/sdk/identity.dart 0.00% 2 Missing ⚠️
lib/iden3comm/authenticate.dart 0.00% 1 Missing ⚠️
...m/domain/use_cases/fetch_credentials_use_case.dart 0.00% 1 Missing ⚠️
...cases/get_current_env_did_identifier_use_case.dart 0.00% 1 Missing ⚠️
...main/use_cases/identity/get_identity_use_case.dart 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #424   +/-   ##
========================================
  Coverage    21.77%   21.77%           
========================================
  Files          297      297           
  Lines         9272     9290   +18     
========================================
+ Hits          2019     2023    +4     
- Misses        7253     7267   +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@plusema86 plusema86 merged commit dfefbbc into develop Jul 25, 2024
2 checks passed
@plusema86 plusema86 deleted the feature/PID2274-support-privado-network branch July 25, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants