Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of the accounts method #2190

Conversation

novosandara
Copy link

Description

Implementation of the accounts method

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • [ x] New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Checklist

  • [ x] I have assigned this PR to myself
  • [ x] I have added at least 1 reviewer
  • [x ] I have added the relevant labels
  • I have updated the official documentation
  • [ x] I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Documentation update

Additional comments

bane and others added 30 commits March 8, 2024 14:32
* Bump github.com/go-jose/go-jose/v3 from 3.0.1 to 3.0.3

Bumps [github.com/go-jose/go-jose/v3](https://github.com/go-jose/go-jose) from 3.0.1 to 3.0.3.
- [Release notes](https://github.com/go-jose/go-jose/releases)
- [Changelog](https://github.com/go-jose/go-jose/blob/v3.0.3/CHANGELOG.md)
- [Commits](go-jose/go-jose@v3.0.1...v3.0.3)

---
updated-dependencies:
- dependency-name: github.com/go-jose/go-jose/v3
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* Format go.mod

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Stefan Negovanović <[email protected]>
Bumps gopkg.in/DataDog/dd-trace-go.v1 from 1.60.0 to 1.61.0.

---
updated-dependencies:
- dependency-name: gopkg.in/DataDog/dd-trace-go.v1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* added versioning flags

* comment fix

---------

Co-authored-by: Stefan Negovanović <[email protected]>
* Change the way EVM benchmark subtests are ran

* Remove redundant listFolders call

* Do not execute EVM state tests multiple times

* Remove listFolders function
* added contructor for all types of transactions

* legacy transaction test fix

* other transactions test fix

* legacy test fix

* state test fix

* comment fix
This reverts commit 23c746e, reversing
changes made to 6501516.
Bumps google.golang.org/protobuf from 1.32.0 to 1.33.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* New EthClient

* Remove unused code

* CallMsg

* e2e test

* Lint fix

* Remove temporary test

* Fix e2e test

* Fix the tests version

* Go mod tidy and use the Keccak256 from the crypto pkg

* Place github.com/valyala/fastjson among the direct deps

* Comments fix

---------

Co-authored-by: Stefan Negovanović <[email protected]>
…ng logic (#112)

* Introduce ECDSAKey and decouple from ethgo transactions signing logic

* Fix panic in e2e test(s)

* Fix checkpoint manager unit tests

* Try to fix extract signature failure

* Change signature of sign callback function

* Use the latest signer in the tx relayer

* Minor fixes

* Fix panic when unsigned transaction is sent to txrelayer

* Instantiate LondonOrBerlin signer in the TestCluster.SendTxn

* Minor change

* Lint fix

* Build fixes

* Add log to tx pool

* Typo fix and small simplification

* Build fix

* callback function fix

* rebase fixes

* lint fix

* fixes for e2e

* migration test fix

* transactionWithHeaderInstructions fix

* Fix linters

* Fix linter (uncapitalize param name)

* Remove debug log

* Adapt the unit test

* Merge fix

* Fix TestE2E_JsonRPC_NewEthClient

* Lint fix

* comment fix

* lint fix

* test fix

* one more transaction contructor

---------

Co-authored-by: Dusan Nosovic <[email protected]>
oliverbundalo and others added 26 commits June 21, 2024 16:35
…lop-github.com-libp2p-go-libp2p-pubsub-0.11.0

Bump github.com/libp2p/go-libp2p-pubsub from 0.10.1 to 0.11.0
* Add Sanity Check Tests

* Increase ldb write benchmark time for 1s

* Minor fixes

* sanity test err fix

* small fixes in sanity check tests

* Change `epoch_reward` value

* Change `reward_wallet_balance` value

* sanity check tests fix

* lint fix

* sanity check tests fix

* Fix `ec2` filter

---------

Co-authored-by: Oliver Bundalo <[email protected]>
Co-authored-by: Goran Rojovic <[email protected]>
* eth_signTransaction implementation

* deletion of unnecessary parameter from decodeTxn

* fix for debug_endpoint

* fix for tests

* return value fix

* fixes

* comments fix

---------

Co-authored-by: Goran Rojovic <[email protected]>
Bumps [github.com/hashicorp/go-retryablehttp](https://github.com/hashicorp/go-retryablehttp) from 0.7.6 to 0.7.7.
- [Changelog](https://github.com/hashicorp/go-retryablehttp/blob/main/CHANGELOG.md)
- [Commits](hashicorp/go-retryablehttp@v0.7.6...v0.7.7)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/go-retryablehttp
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* eth_sendTransaction

* comments fix
TestE2E_Bridge_NonMintableERC20Token_WithPremine fix
Bumps gopkg.in/DataDog/dd-trace-go.v1 from 1.64.0 to 1.65.1.

---
updated-dependencies:
- dependency-name: gopkg.in/DataDog/dd-trace-go.v1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…lop-gopkg.in-DataDog-dd-trace-go.v1-1.65.1

Bump gopkg.in/DataDog/dd-trace-go.v1 from 1.64.0 to 1.65.1
Bumps [github.com/multiformats/go-multiaddr](https://github.com/multiformats/go-multiaddr) from 0.12.4 to 0.13.0.
- [Release notes](https://github.com/multiformats/go-multiaddr/releases)
- [Commits](multiformats/go-multiaddr@v0.12.4...v0.13.0)

---
updated-dependencies:
- dependency-name: github.com/multiformats/go-multiaddr
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.21.1-0.20240508182429-e35e4ccd0d2d to 0.22.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](https://github.com/golang/tools/commits/v0.22.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…lop-golang.org-x-tools-0.22.0

Bump golang.org/x/tools from 0.21.1-0.20240508182429-e35e4ccd0d2d to 0.22.0
Bumps [github.com/erigontech/mdbx-go](https://github.com/erigontech/mdbx-go) from 0.38.0 to 0.38.4.
- [Release notes](https://github.com/erigontech/mdbx-go/releases)
- [Changelog](https://github.com/erigontech/mdbx-go/blob/master/CHANGES.md)
- [Commits](erigontech/mdbx-go@v0.38.0...v0.38.4)

---
updated-dependencies:
- dependency-name: github.com/erigontech/mdbx-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.53.14 to 1.54.12.
- [Release notes](https://github.com/aws/aws-sdk-go/releases)
- [Commits](aws/aws-sdk-go@v1.53.14...v1.54.12)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…lop-github.com-aws-aws-sdk-go-1.54.12

Bump github.com/aws/aws-sdk-go from 1.53.14 to 1.54.12
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.8.0 to 1.8.1.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.8.0...v1.8.1)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…lop-github.com-spf13-cobra-1.8.1

Bump github.com/spf13/cobra from 1.8.0 to 1.8.1
Bumps [github.com/schollz/progressbar/v3](https://github.com/schollz/progressbar) from 3.14.3 to 3.14.4.
- [Release notes](https://github.com/schollz/progressbar/releases)
- [Commits](schollz/progressbar@v3.14.3...v3.14.4)

---
updated-dependencies:
- dependency-name: github.com/schollz/progressbar/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps google.golang.org/protobuf from 1.34.1 to 1.34.2.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…mpatible (#308)

* Bump github.com/docker/docker

Bumps [github.com/docker/docker](https://github.com/docker/docker) from 26.1.3+incompatible to 27.0.3+incompatible.
- [Release notes](https://github.com/docker/docker/releases)
- [Commits](moby/moby@v26.1.3...v27.0.3)

---
updated-dependencies:
- dependency-name: github.com/docker/docker
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Build fix

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Stefan Negovanović <[email protected]>
Bumps [cloud.google.com/go/secretmanager](https://github.com/googleapis/google-cloud-go) from 1.13.1 to 1.13.3.
- [Release notes](https://github.com/googleapis/google-cloud-go/releases)
- [Changelog](https://github.com/googleapis/google-cloud-go/blob/main/CHANGES.md)
- [Commits](googleapis/google-cloud-go@asset/v1.13.1...redis/v1.13.3)

---
updated-dependencies:
- dependency-name: cloud.google.com/go/secretmanager
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Copy link

github-actions bot commented Jul 2, 2024

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


3 out of 6 committers have signed the CLA.
@dusannosovic-ethernal
@goran-ethernal
@Stefan-Ethernal
@bane
@oliverbundalo
@novosandara
You can retrigger this bot by commenting recheck in this Pull Request

@novosandara novosandara closed this Jul 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
@novosandara novosandara deleted the Implementation_of_the__Accounts_method branch July 2, 2024 20:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants