Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix BuildVersions during cargo build #258

Merged
merged 1 commit into from
Jan 9, 2025
Merged

feat: fix BuildVersions during cargo build #258

merged 1 commit into from
Jan 9, 2025

Conversation

ToniRamirezM
Copy link
Contributor

@ToniRamirezM ToniRamirezM commented Jan 9, 2025 •
edited
Loading

Description

Fixes function BuildVersions that was preventing make build-docker command to work.

Fixes #257

@ToniRamirezM ToniRamirezM self-assigned this Jan 9, 2025
@ToniRamirezM ToniRamirezM requested review from vcastellm and a team January 9, 2025 11:56
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vcastellm
vcastellm approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ToniRamirezM ToniRamirezM merged commit ff9ce60 into develop Jan 9, 2025
13 of 14 checks passed
@ToniRamirezM ToniRamirezM deleted the feat/fixBuildVersions branch January 9, 2025 15:29
rachit77 pushed a commit that referenced this pull request Jan 10, 2025
@ToniRamirezM @rachit77
feat: fix BuildVersions during cargo build (#258)
4b8e234
@rachit77 rachit77 mentioned this pull request Jan 10, 2025
Merged
goran-ethernal pushed a commit that referenced this pull request Jan 10, 2025
@ToniRamirezM @goran-ethernal
feat: fix BuildVersions during cargo build (#258)
ec678a9
rachit77 added a commit that referenced this pull request Jan 10, 2025
@rachit77 @ToniRamirezM
feat: fix BuildVersions during cargo build (#258) (#260)
ea67896 
Co-authored-by: Toni Ramírez <[email protected]>
rachit77 pushed a commit that referenced this pull request Jan 10, 2025
@ToniRamirezM @rachit77
feat: fix BuildVersions during cargo build (#258)
db2393c
goran-ethernal added a commit that referenced this pull request Jan 13, 2025
@goran-ethernal @ToniRamirezM @Stefan-Ethernal
feat: more logs for l1infotreesyncer (#262)
4c9af9c 
* feat: add new db migartion

* feat: save block hash to block table and add more logs

* feat: fix BuildVersions during cargo build (#258)

* fix: increase log level

* fix: processor logger

* fix: e2e tests

* fix: remove unnecessary environment variables from e2e workflow

* fix: update reference to Kurtosis CDK version 0.2.25 in e2e workflow

* fix: refactor e2e workflow (1st attempt)

---------

Co-authored-by: Toni Ramírez <[email protected]>
Co-authored-by: Stefan Negovanović <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@temaniarpit27 temaniarpit27 temaniarpit27 approved these changes

@vcastellm vcastellm vcastellm approved these changes

Assignees

@ToniRamirezM ToniRamirezM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ToniRamirezM @vcastellm @temaniarpit27