feat: e2e test Pesimisstic L2 to L2 claim #239

joanestebanr · 2024-12-10T16:02:24Z

Description

The PR add e2e test for L2 to L2 bridge. To do this it require several improvements:

Check the settle certificate contents to see if a deposit is included. For that is used global_index. It needs, a RPC to get the submitted certificates and also a new tool to find the global_index

E2E

The new test is a new check because it need a specific version of kurtosis-cdk that is still on a branch
It have a new way of doing bridges / claims: bridgeAsset export the tx_hash and claim only claim the specific deposit

RPC for aggsender

In order to be able to retrieve all certificates for verify which one contain the desired importedBridgeExit have create a aggsender end-point.

Changed RPC behaviour. Now to start bridge service, instead of RPC component, you must use BRIDGE component
Aggsender provide RPC service can be disabled from config file: AggSender.EnableRPC
Available methods:
aggsender_getCertificateHeaderPerHeight: you can ask for highest certificate of an specific height.
Example of usage for requesting the highest height:

curl -X POST http://localhost:5576/ -H "Con -application/json"   -d {"method":"aggsender_getCertificateHeaderPerHeight", "params":[], "id":1}'

aggsender_status

Tools

Add new folder tools:

New Makefile taget build-tools
currently there are only one: aggsender_find_imported_bridge: find out a importedBridgeExit in settled certificates of aggsender, it use RPC to retrieve certificates, also require to be able to unmarshal certificates

aggsender_find_imported_bridge <code_rpc> <global_index>

Configuration changes

DryRun: allow to prevent aggsender to submit certificates
EnableRPC: It create a end point

[AggSender]
DryRun = false
EnableRPC = true

* Simplify HashMeddler * fix: TestCertificateHeaderString UT

…t lower than in local storage (#209)

This set a limit on certificate size that can be set on config file (the size of certificate it's an estimation) There are a special situation that is going to send a certificate bigger than maximium: - [ initial_block, end_block ] -> size exceed - [ initial_block, (end_block -1) ] -> no bridges, so we have to send previous one even that exceed the maximum size MaxCertSize: max size in bytes of certificate. Default 8Mb. Currently the maximum on Agglayer is 10Mb ``` [AggSender] MaxCertSize = 8388608 ```

* fix: use hex instead of byte arrays * feat: UT * fix: change estimated certificate size * fix: UT coverage * fix: bridge exit metadata hash * fix: last sent certificate block (#234)

…agglayer (#227) * chore: update the versions.json * Remove PPError interface and use the error instead * Remove non-applicable test cases * Rename * test: increase UT coverage * test: certificate status unmarshal json * test: TestMerkleProofString * test: TestGlobalIndexString * test: move helper functions to a separate file * test: TestL1InfoTreeLeafString * test: TestClaimType * test: parallel execution, renames

…t` hash (#237) * fix: calculate correct root for LER merkle proof, and fix BridgeExit hash * fix: UTs * fix: comments

…), so it's retried

aggsender/rpc/aggsender_rpc.go

agglayer/types.go

version_test.go

test/bats/pp-multi/bridge-l2_to_l2-e2e.bats

tools/aggsender_find_imported_bridge/aggsender_find_imported_bridge.go

aggsender/rpcclient/client.go

Stefan-Ethernal

Generally LGTM, leaving a couple of more comments to consider.

aggsender/aggsender.go

test/helpers/common-multi_cdk-setup.bash

aggsender/aggsender.go

test/bats/pp-multi/bridge-l2_to_l2-e2e.bats

test/bats/helpers/common-multi_cdk-setup.bash

test/bats/helpers/lxly-bridge.bash

Dockerfile

agglayer/types.go

agglayer/types_test.go

aggsender/rpc/aggsender_rpc.go

aggsender/aggsender.go

test/Makefile

version.go

sonarqubecloud · 2024-12-20T13:09:07Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vcastellm

LGTM

joanestebanr self-assigned this Dec 10, 2024

joanestebanr added config ci aggsender labels Dec 18, 2024

joanestebanr changed the base branch from release/v0.5.0 to develop December 19, 2024 07:19

joanestebanr changed the base branch from develop to release/v0.5.0 December 19, 2024 07:19

Stefan-Ethernal and others added 23 commits December 19, 2024 12:27

chore: simplify the HashMeddler (#205)

aa572c0

* Simplify HashMeddler * fix: TestCertificateHeaderString UT

feat: return an error in case agglayer returns certificate with heigh…

e8ba6b9

…t lower than in local storage (#209)

bump DAC (#218)

5fe8671

feat: cherry pick PR 229 to release (#233)

c84df07

* fix: use hex instead of byte arrays * feat: UT * fix: change estimated certificate size * fix: UT coverage * fix: bridge exit metadata hash * fix: last sent certificate block (#234)

fix: calculate correct root for LER merkle proof and fix `BridgeExi…

61db2b1

…t` hash (#237) * fix: calculate correct root for LER merkle proof, and fix BridgeExit hash * fix: UTs * fix: comments

feat: wip

c684718

feat: wip, still missing test certificate

2b1a61d

feat: wip, fix polycli

96b7f5d

feat: wip

4f1c47f

feat: wip

152167b

feat: wip

d1ade90

feat: fix cert error

32af660

feat: wip

a80eba1

fix: e2e

922b0f1

feat: sometimes fails the claim of L2->L2 with GlobalExitRootInvalid(…

41594ae

…), so it's retried

feat: RPC for aggsender,previous component RPC is called BRIDGE

6d1f19e

feat: improve bats

1a51719

feat: support unmarshal for certificate

0605d97

feat: add aggsender RPC

46523ea

feat: increase coverage

4dac97c

feat: add tools

41e0001

Stefan-Ethernal reviewed Dec 19, 2024

View reviewed changes

aggsender/rpc/aggsender_rpc.go Outdated Show resolved Hide resolved

joanestebanr added 4 commits December 19, 2024 12:48

feat: increase coverage

759cabf

feat: increase coverage

a36f31b

fix: lint

c2748ec

fix: rebase errors

77d5fcf

joanestebanr force-pushed the feature/e2e_l2_to_l2 branch from af3e06f to 77d5fcf Compare December 19, 2024 13:51

joanestebanr changed the base branch from release/v0.5.0 to develop December 19, 2024 13:51

Stefan-Ethernal reviewed Dec 19, 2024

View reviewed changes

joanestebanr added 4 commits December 19, 2024 15:50

feat: add more info to RPC status

c465e2d

fix: PR comments

51af863

fix: unittest

adb73d1

fix: e2e

98c2e9f

joanestebanr requested review from Stefan-Ethernal, arnaubennassar, vcastellm and goran-ethernal December 19, 2024 15:52

Stefan-Ethernal approved these changes Dec 20, 2024

View reviewed changes

fix: PR comments

1fb05b8

goran-ethernal reviewed Dec 20, 2024

View reviewed changes

joanestebanr added 2 commits December 20, 2024 12:18

fix: PR comments

78724d2

fix: PR comments

8113e91

joanestebanr requested a review from goran-ethernal December 20, 2024 11:45

goran-ethernal approved these changes Dec 20, 2024

View reviewed changes

vcastellm reviewed Dec 20, 2024

View reviewed changes

test/Makefile Show resolved Hide resolved

vcastellm reviewed Dec 20, 2024

View reviewed changes

version.go Show resolved Hide resolved

PR: comments

0638b0b

rachit77 approved these changes Dec 20, 2024

View reviewed changes

vcastellm approved these changes Dec 20, 2024

View reviewed changes

joanestebanr merged commit 6e5bd04 into develop Dec 20, 2024
14 checks passed

joanestebanr deleted the feature/e2e_l2_to_l2 branch December 20, 2024 15:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: e2e test Pesimisstic L2 to L2 claim #239

feat: e2e test Pesimisstic L2 to L2 claim #239

joanestebanr commented Dec 10, 2024 •

edited

Loading

Stefan-Ethernal left a comment

sonarqubecloud bot commented Dec 20, 2024

vcastellm left a comment

feat: e2e test Pesimisstic L2 to L2 claim #239

feat: e2e test Pesimisstic L2 to L2 claim #239

Conversation

joanestebanr commented Dec 10, 2024 • edited Loading

Description

E2E

RPC for aggsender

Tools

Configuration changes

Stefan-Ethernal left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Dec 20, 2024

Quality Gate passed

vcastellm left a comment

Choose a reason for hiding this comment

joanestebanr commented Dec 10, 2024 •

edited

Loading