feat: use the GenericError for all the errors originating from the agglayer
#227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
approved these changes
Dec 5, 2024
Stefan-Ethernal
force-pushed
the
CDK-605-aggsender-check-that-an-error-parsing-certificate-header-error-doesnt-make-fail-the-transaction
branch
from
41abcd2 to
818d053
Compare
Stefan-Ethernal
force-pushed
the
CDK-605-aggsender-check-that-an-error-parsing-certificate-header-error-doesnt-make-fail-the-transaction
branch
from
818d053 to
af40d3f
Compare
Stefan-Ethernal
force-pushed
the
CDK-605-aggsender-check-that-an-error-parsing-certificate-header-error-doesnt-make-fail-the-transaction
branch
4 times, most recently
from
0623926 to
291e61d
Compare
Stefan-Ethernal
force-pushed
the
CDK-605-aggsender-check-that-an-error-parsing-certificate-header-error-doesnt-make-fail-the-transaction
branch
from
e64ecb0 to
b308598
Compare
Stefan-Ethernal
changed the title
GenericError from all the errors originating from the agglayerGenericError for all the errors originating from the agglayer
|
joanestebanr
approved these changes
Dec 9, 2024
Stefan-Ethernal
deleted the
CDK-605-aggsender-check-that-an-error-parsing-certificate-header-error-doesnt-make-fail-the-transaction
branch
Stefan-Ethernal
added a commit
that referenced
this pull request
Dec 9, 2024
…agglayer (#227) * chore: update the versions.json * Remove PPError interface and use the error instead * Remove non-applicable test cases * Rename * test: increase UT coverage * test: certificate status unmarshal json * test: TestMerkleProofString * test: TestGlobalIndexString * test: move helper functions to a separate file * test: TestL1InfoTreeLeafString * test: TestClaimType * test: parallel execution, renames
Stefan-Ethernal
added a commit
that referenced
this pull request
Dec 10, 2024
…agglayer (#227) * chore: update the versions.json * Remove PPError interface and use the error instead * Remove non-applicable test cases * Rename * test: increase UT coverage * test: certificate status unmarshal json * test: TestMerkleProofString * test: TestGlobalIndexString * test: move helper functions to a separate file * test: TestL1InfoTreeLeafString * test: TestClaimType * test: parallel execution, renames
Stefan-Ethernal
added a commit
that referenced
this pull request
Dec 10, 2024
…agglayer (#227) (#236) * chore: update the versions.json * Remove PPError interface and use the error instead * Remove non-applicable test cases * Rename * test: increase UT coverage * test: certificate status unmarshal json * test: TestMerkleProofString * test: TestGlobalIndexString * test: move helper functions to a separate file * test: TestL1InfoTreeLeafString * test: TestClaimType * test: parallel execution, renames
joanestebanr
pushed a commit
that referenced
this pull request
Dec 19, 2024
…agglayer (#227) * chore: update the versions.json * Remove PPError interface and use the error instead * Remove non-applicable test cases * Rename * test: increase UT coverage * test: certificate status unmarshal json * test: TestMerkleProofString * test: TestGlobalIndexString * test: move helper functions to a separate file * test: TestL1InfoTreeLeafString * test: TestClaimType * test: parallel execution, renames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the
GenericErrorfor all the errors originating from theagglayer. Even in case some error occurs when unmarshalling, suppress propagation and embed it into theGenericErrorinstance.