feat: Banana changes on sequence sender
#15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
changed the title
Banana changes on sequence senderBanana changes on sequence sender
goran-ethernal
force-pushed
the
CDK-260-sequence-sender-integrate-banana
branch
from
86bc8e4 to
9bb2676
Compare
joanestebanr
approved these changes
Jul 11, 2024
joanestebanr
requested changes
Jul 12, 2024
joanestebanr
approved these changes
Jul 15, 2024
arnaubennassar
approved these changes
Jul 16, 2024
| @@ -995,7 +1004,7 @@ func (s *SequenceSender) addInfoSequenceBatchEnd(batch *datastream.BatchEnd) { | |||
| if data != nil { | |||
| wipBatch := data.batch | |||
| if wipBatch.BatchNumber == batch.Number { | |||
| wipBatch.StateRoot = common.BytesToHash(batch.StateRoot) | |||
| // wipBatch.StateRoot = common.BytesToHash(batch) TODO: check if this is needed | |||
There was a problem hiding this comment.
Do we know what is the outcome of this TODO?
cc @arnaubennassar do we need to set the StateRoot for the WIP batch?
Co-authored-by: Stefan Negovanović <[email protected]>
Co-authored-by: Stefan Negovanović <[email protected]>
Co-authored-by: Stefan Negovanović <[email protected]>
Co-authored-by: Stefan Negovanović <[email protected]>
Co-authored-by: Goran Rojovic <[email protected]>
goran-ethernal
force-pushed
the
CDK-260-sequence-sender-integrate-banana
branch
from
8b22abb to
1b33233
Compare
|
Stefan-Ethernal
added a commit
that referenced
this pull request
Sep 17, 2024
* banana changes * fix: old acc input hash fix * fix: update DAC dependency * fix: move seqence struct to etherman package * fix: move CalculateAccInputHash to common package * fix: datacommittee contract to point to banana * fix: ut * wip * remove IsValidium from seqSender code * remove unused file * renamed * wip * add errors * revert multi-fork for etherman and remove wrappers for contracts * add elderberry validium * wip-elderberry validium * add translator to override DAC members URLs * add auto-config kurtosis environment * fix bugs, fix kurtosis config * maxbatchesforL1=0 -> disabled * wip * fix script * add e2e test * comments on PR * wip * wip * wip * wip * add verify batches check * test * wip * wip * placeholder for testing GHaction * wip * wip * wip * wip * wip * wip * wip * disabled datacommitte test because PUSH0 is not supported by geth simulated * wip * PR comments * Update dataavailability/datacommittee/datacommittee.go Co-authored-by: Stefan Negovanović <[email protected]> * PR comments * Update dataavailability/datacommittee/datacommittee_test.go Co-authored-by: Stefan Negovanović <[email protected]> * Update test/scripts/config_kurtosis_for_local_run.sh Co-authored-by: Stefan Negovanović <[email protected]> * PR comments * Update test/config/test.kurtosis_template.toml Co-authored-by: Stefan Negovanović <[email protected]> * PR comments * PR comments * PR comments * PR comments * PR comments * Update cmd/run.go Co-authored-by: Goran Rojovic <[email protected]> * PR comments * fix Dockerfile * fix: race conditions in reorg detector --------- Co-authored-by: joanestebanr <[email protected]> Co-authored-by: Stefan Negovanović <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Bananafork changes to thesequence sender. Mainly:DACendpoint calledSignSequenceBananato sign a new sequence.L1InfoRootIndexfor the sequence and sending it to the contract.accumulated input hashfor the new sequence.