-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Qdrant support #81
Conversation
Signed-off-by: Anush008 <[email protected]>
Hey, thanks for the PR! We appreciate your contributions! Before we take a closer look at your PR, can you fill in your PR description to add some more details? We have a PR template here which contains a format that should help in organizing more info about your PR. I would also include some specific points about implementation, especially since the team might not be as familiar with this vector store and some of the quirks that might be different than other ones (like I'm unsure why Also, this PR touches some Lastly, for testing, we don't have our integration testing fully figured out (as per #68). When we do, we will come back to this and add testing. I would include a description on how you verified and manually tested this integration with clear instructions for us to replicate so that we can better test this PR and perhaps in the future, leverage it for some automated integration testing. |
That was from cargo clippy --fix |
Added to the PR description |
Could you elaborate in the diff? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a quick review, I (or someone else) will do a proper review later!
Signed-off-by: Anush008 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done! Thank you for your contribution 😁
Actually @Anush008 I did not realize that CI had not been run yet, if you could address the failing checks we can merge after that! |
Signed-off-by: Anush008 <[email protected]>
Hey @cvauclair. Could you please approve the CI? |
Description
Adds support for Qdrant - https://qdrant.tech/ to be used as vector store in Rig.
Resolves #2
Testing
I've QA tested and you can run the example with
You can view the data at http://localhost:6333/dashboard
Checklist: