Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/split-wallet-refix #1645

Open
wants to merge 1 commit into
base: sprint-1.18
Choose a base branch
from
Open

fix/split-wallet-refix #1645

wants to merge 1 commit into from
+1 −1

Conversation

yash10019coder
Copy link
Member

Changes

  • pass client id properly in wasm proxy.go

Fixes

  • fix wasm gosdk.

Tests

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

  • blobber:
  • 0chain:
  • system_test:
  • zboxcli:
  • zwalletcli:
  • Other: ...

@yash10019coder yash10019coder changed the base branch from staging to fix/split-wallet October 22, 2024 19:29
Base automatically changed from fix/split-wallet to sprint-1.18 October 23, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterlimg peterlimg Awaiting requested review from peterlimg peterlimg is a code owner

@dabasov dabasov Awaiting requested review from dabasov dabasov is a code owner

@guruhubb guruhubb Awaiting requested review from guruhubb guruhubb is a code owner

@Jayashsatolia403 Jayashsatolia403 Awaiting requested review from Jayashsatolia403

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yash10019coder