Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to distinguish between no updates available and no updates supported #82

Open
raman325 opened this issue Sep 1, 2023 · 1 comment

Comments

@raman325
Copy link

raman325 commented Sep 1, 2023

Today, if you query the firmware update service, you will only see updates if there are firmware updates available for the device in question. When you don't see any updates, however, it's hard to know whether that means that the device IS supported by the update service but has no updates available or the device ISN'T supported by the update service and therefore has no updates available.

One suggestion @AlCalzone had on Discord was to return a null instead of an empty list to indicate that the device is not supported by the service. Not sure if this needs to go into the service itself or into the caller, but starting here for tracking purposes

@AlCalzone
Copy link
Member

One thing we may have to consider: Some devices are gated by firmware version, e.g. the recently Aeotec devices. If you are on their latest version, no file will match, so without further checks (i.e. does a file exist for any firmware version?), the service response would be not supported. So I guess we'd also need to check if there is an update available to the current version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants