Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Q] Existing Header Image is not supported #33

Open
Sarsewar opened this issue Jan 13, 2025 · 5 comments
Open

[Q] Existing Header Image is not supported #33

Sarsewar opened this issue Jan 13, 2025 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@Sarsewar
Copy link

💬 Existing Header image is not supported

Header images are currently being removed in Microsoft Excel when using ExcelJS.

The feature to handle this issue is addressed in exceljs/exceljs#2563; however, shapes and comments are also being removed despite being supported in the latest ExcelJS version (4.4.0).

According to exceljs/exceljs#2574, version 4.5.0 is expected to fully support this functionality. However, I would like to utilize this feature now.

@zurmokeeper, could you merge this into your branch, or provide guidance on how to proceed? Your assistance would be greatly appreciated.


@zurmokeeper
Copy link
Owner

@Sarsewar

From the comments under PR exceljs/exceljs#2563 , does it mean that just merging PR 2563 meets your functional requirements? Or does it still need the content of PR 2077 to make your requirement work?

@zurmokeeper zurmokeeper self-assigned this Jan 13, 2025
@Sarsewar
Copy link
Author

@zurmokeeper 2563 meets functional requirements of header image support but I guess it has bugs . The existing comments and drawing shapes were being removed. But Exceljs latest version 4.4.0 supports comments and drawing shapes. I want all three(header image,comments & Drawing shapes) to work in a single version.

@zurmokeeper
Copy link
Owner

zurmokeeper commented Jan 13, 2025

@Sarsewar I'll take a look with this branch of the code, if it's the same as stated here, then there should be a compatibility issue with MS Office, right?

exceljs/exceljs#2077

exceljs/exceljs#2601

@Sarsewar
Copy link
Author

Yes @zurmokeeper

@zurmokeeper zurmokeeper added the enhancement New feature or request label Jan 16, 2025
@Sarsewar
Copy link
Author

@zurmokeeper Any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants