-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect group permissions handling? #152
Comments
Two situations depending on what user did when user saw "You can't write to group '%s' anymore. What would you like to do?":
Also with this fix this dialog will no longer appear for cases where the admin of the group is also the owner of the same group. Line 44 in b25c77a
|
"Keep changes" is from iOS? I'm actually not sure what that does — maybe @michalrentka or @mvasilak can comment. On the desktop, if you lose write access to a group, we show this:
Or for file write access:
With buttons "Reset Group [Files] and Sync" and "Skip Group". The only options here should be to skip syncing of the group or to reset locally modified items or files to the server state. We never want to just clear pending local uploads. If we're doing that on iOS, we should definitely fix that. |
We do have the right error message and we have options "Revert to original" and "Keep changes". "Keep changes" doesn't skip syncing of the whole group, it just marks those changes as synced and ignores them on next sync. Revert does what it should. Anyway if we skip syncing of one group we can't re-enable it later because we don't support that on iOS yet, so that wouldn't really make sense? Maybe that's why we chose this path? |
But that's really bad, no? It means that those changes will never be uploaded, even if you fix the permissions, and your library could be permanently out of sync (unless you edit each of the same objects to trigger reuploading).
Don't support what, exactly? Skipping the group here really just means moving on to the next group for this sync. This message can keep appearing on the next sync. (Or it could maybe automatically skip if we hit the same error until the next manual sync or app startup, and then show again.) Or do you mean even that wouldn't work, because of some way we're handling version numbers or something on iOS? |
Yes, those changes stay local "forever". It's been implemented like that as long as I can remember, I don't remember the reasoning behind it.
I thought you would mark the library to skip syncing until you enable it in settings again. If it just keeps popping up each sync then that wouldn't be a problem even on iOS. |
Yeah, the idea here is just that you click Skip Group and then go talk to the group admin and ask them to fix permissions and then try again. If it's not going to be fixed, you revert local changes. |
https://forums.zotero.org/discussion/115481/android-different-group-permissions-than-on-desktop
The text was updated successfully, but these errors were encountered: