SpecialUsers.super is deprecated

[icemac]

According to the code SpecialUsers.super is deprecated.

Task: Add a deprecation warning when using it proposing its removal in AccessControl 6.

[jugmac00]

Hm, this seems to be pretty complicated.

There is __get_attr__ for modules with Python 3.7+, which we cannot use now.

I tried a couple of ways, but with no success.

I am definitely willing to buy a couple of beers for the one providing a working solution at the next in person sprint.

[icemac]

@jugmac00 We have zope.deprecation, see https://zopedeprecation.readthedocs.io/en/latest/api.html#deprecating-objects-inside-a-module.

So zope.deprecation.deprecated(super, 'super is deprecated, ... blah') should do the trick. (untested 😉)

[jugmac00]

SuperUsers.super is a module level constant in AccessControl.SuperUsers, but SuperUsers.super is monkeypatched in AccessControl.users as following 🤯

AccessControl/src/AccessControl/users.py

Line 411 in 5af868c

SpecialUsers.super = emergency_user

I experimented also with turning SuperUsers into a class, but there are some serious circular imports going on.