Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes in PR titles cause slack notification to fail #78

Open
zwolf opened this issue Apr 25, 2024 · 0 comments
Open

Quotes in PR titles cause slack notification to fail #78

zwolf opened this issue Apr 25, 2024 · 0 comments

Comments

@zwolf
Copy link
Member

zwolf commented Apr 25, 2024

PR titles are passed to the slack notification shared workflow via argument. When the PR contains double quotes (as here) they are not escaped properly and the action fails like this:

Run 8398a7/action-slack@v3
  with:
    job_name: Build Staging Image
    fields: took
    status: custom
    ...
  env:
    PR_URL: https://github.com/zooniverse/front-end-monorepo/pull/4436
    PR_TITLE: Classifier: change Annotate Button icon to "edit/pencil"
    SLACK_WEBHOOK_URL: ***
Error: Unexpected identifier 'edit'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant