Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getDepositTx is not properly typed #230

Open
cytadela8 opened this issue Jan 13, 2025 · 1 comment
Open

getDepositTx is not properly typed #230

cytadela8 opened this issue Jan 13, 2025 · 1 comment

Comments

@cytadela8
Copy link
Contributor

cytadela8 commented Jan 13, 2025 •
edited
Loading

🌟 Feature Request

📝 Description

getDepositTx has return value Promise<any>. It should be properly typed.

zksync-ethers/src/adapters.ts

Line 782 in 6476368

}): Promise<any> {

🤔 Rationale

It seems to me this is not difficult to implement, as when I go 2 functions deep I can see things are typed properly.

📋 Additional Context

image
@danijelTxFusion
Copy link
Collaborator

@cytadela8 Thank you for mentioning this, it will be resolved.

@danijelTxFusion danijelTxFusion moved this to Todo in DevEx squad Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cytadela8 @danijelTxFusion