Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests for findAndLabel and trainMatch #901

Open
sonalgoyal opened this issue Sep 30, 2024 · 4 comments
Open

tests for findAndLabel and trainMatch #901

sonalgoyal opened this issue Sep 30, 2024 · 4 comments
Assignees

Comments

@sonalgoyal
Copy link
Member

we need integration tests for these

@sania-16
Copy link
Contributor

sania-16 commented Oct 2, 2024

These tests have to be in TestExecutorsGeneric.java or in a different file?

@sonalgoyal
Copy link
Member Author

You can create a new test extending TestExecutorGeneric. Call it TestExecutorsCompoundPhases or something and overide testExecutors? See if that works.

@sania-16
Copy link
Contributor

sania-16 commented Oct 2, 2024

  • we make new testers for them in executor - findandlabeltester and trainMatchtester
  • we define them with using object of trainingdatatester and labellertester for validateresults function - override it
  • for trainMatch not sure how to do it because of accuracy test - how to proceed?

@sonalgoyal
Copy link
Member Author

we should find and label till we have at least 10 matching records on febrl dataset before we assert accuracy. I think that should do it in both cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants