New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insufficient alias flattening while teaching #131

Open

dgw opened this issue Dec 29, 2019 · 0 comments

Labels

bug

Collaborator

dgw commented Dec 29, 2019

Only one level of aliases is removed when learning. Teaching to a chain of aliases can end up adding the new factoid to an alias still.

For example, say the database contains these aliases:
'foo' <alias> 'bar'
'bar' <alias> 'baz'

Teaching "Bucket, foo is spam eggs":
'bar' is 'spam eggs' added to database.

This doesn't seem right. Aliases shouldn't have other factoids. It can lead to e.g. #45.

dgw added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment