Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare script in package.json is incorrect #15

Open
vucinatim opened this issue Apr 22, 2024 · 0 comments
Open

prepare script in package.json is incorrect #15

vucinatim opened this issue Apr 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@vucinatim
Copy link
Member

Current Behavior

// package.json
"scripts": {
    ...
    "prepare": "husky install",
    ...
},

Expected Behavior

// package.json
"scripts": {
    ...
    "prepare": "npm run build",
    ...
},

Explanation

The "prepare" command is executed right after package installation.
The package should be built in "prepare" step (instead of running husky install which is not needed in that case anyway).
Not building the package in prepare means that if installed directly via github link: npm install https://github.com/zerodays/react-native-gen-ui the installation does not set up the package properly, making it unusable (unless the package is then built manually in the node_modules). This needs to be done because the /lib folder where the built files are inserted is added to .gitignore.

@vucinatim vucinatim added the bug Something isn't working label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant