You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So, is it wrong to assume that we can use sys_set_bit() for MMIOs? There seems to be many device drivers using sys_set_bit() and sys_clear_bit() for MMIO, IIUC.
The thing is that some (many?) arch has memory barriers in sys_read*() and sys_write*(). But functions from sys_bitops.h don't.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Is there any reason why we don't use
sys_read32()
andsys_write32()
fromsys_set_bit()
? #27098 describes them as :So, is it wrong to assume that we can use
sys_set_bit()
for MMIOs? There seems to be many device drivers usingsys_set_bit()
andsys_clear_bit()
for MMIO, IIUC.The thing is that some (many?) arch has memory barriers in
sys_read*()
andsys_write*()
. But functions from sys_bitops.h don't.Beta Was this translation helpful? Give feedback.
All reactions