Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glance and Keyboard Focus #4687

Open
4 tasks done
RemyPorter opened this issue Jan 29, 2025 · 1 comment
Open
4 tasks done

Glance and Keyboard Focus #4687

RemyPorter opened this issue Jan 29, 2025 · 1 comment

Comments

@RemyPorter
Copy link

RemyPorter commented Jan 29, 2025

Captchas

  • I have read the instructions.
  • I have searched existing issues and avoided creating duplicates.
  • I am not filing an enhancement request.

What happened?

When a newly Glanced pane appears, it doesn't have keyboard focus. I'm not entirely certain where keyboard focus is, but it's not on the pane. This means that I can't scroll using the keyboard (arrow keys, pg up/dn), and extensions like Vimium C don't work correctly (since they don't have focus on the pane).

Clicking on the pane resolves this, as it gives the pane focus. This is a minor nuisance, but as a keyboard-first type person, it makes Glance significantly less useful as a feature.

I've confirmed this behavior on both MacOS and Linux.

Additionally, if an extension (like VimC) traps ESC (because I want to dismiss the VimC overlay) the Glance pane also traps it, thus closing the glance. This may be a bug in the extension (because it's not preventing the bubbling of ESC) or it may be with Glance capturing ESC before the page gets it. Ideal behavior would be for the page/extensions to get first grab of ESC.

Reproducible?

  • I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.7.2b

What platform are you seeing the problem on?

Other

Relevant log output if applicable

@octaviusz
Copy link

I solved the first problem with loss of focus by adding to Vimium C: shortcut userCustomized1 command="visitPreviousTab" strangely enough, this causes the focus to be on the open tab in Glance. And use Ctrl-[ instead of ESC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

2 participants