Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow defining global codeowners #25

Open
sudoforge opened this issue Feb 15, 2020 · 0 comments
Open

Allow defining global codeowners #25

sudoforge opened this issue Feb 15, 2020 · 0 comments

Comments

@sudoforge
Copy link

I think it's important that rules_codeowners allows defining global owners at the project root, separate from a codeowners() rule. Based on the pattern by many other rule sets, this should be done with something like the following:

# WORKSPACE

http_archive(
    name = "rules_codeowners"
    ...
)

load("@rules_codeowners//:foo.bzl", "codeowners_register")

codeowners_register(
    global_owners = [
        "@teamA",
        "@teamB",
    ]
)

This allows defining global owners in the global scope (e.g. at the root of the workspace), but keeps it out of any codeowners() rules for cleaner organization.


Sourced from: #13 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant