Jump to implementation from interface/trait

[goldenratio]

Check for existing issues

• Completed

Describe the feature

in IntelliJ we can easily jump to implementation class, structs, methods, etc..
It will be useful to have similar feature in zed as well.

If applicable, add mockups / screenshots to help present your vision of the feature

and If interface has multiple implementation, a nice clean dropdown will be good

No response

[JosephTLyons]

Hey @goldenratio, just to mention it, we do have a Find All References action, although this will include more than just the impl block of some trait, so it isn't the exact same thing.

[kousikmitra]

This is one things that makes me switch to vs code frequently. ➕ to this request.

[facs95]

+1 here! Are there any plans to implement this?

[SomeoneToIgnore]

We actually have it as an editor action for quite some time:

we_have_it.mov

Underneath, it uses LSP to query for applicable implementations at the location, queried:

zed/crates/project/src/project.rs

Lines 2728 to 2741 in 6cb2afb

	pub fn implementation<T: ToPointUtf16>(
	&mut self,
	buffer: &Model<Buffer>,
	position: T,
	cx: &mut ModelContext<Self>,
	) -> Task<Result<Vec<LocationLink>>> {
	let position = position.to_point_utf16(buffer.read(cx));
	self.request_lsp(
	buffer.clone(),
	LanguageServerToQuery::Primary,
	GetImplementation { position },
	cx,
	)
	}

So if the corresponding language server is able to return that (as for rust-analyzer in the video above), Zed will either navigate straight to the place (if it's a single one) or open a multi buffer with all applicable options (from where, jumping can be done with alt-enter, header or line number click).

What's missing is gutter icons, but not sure if Zed designer team wants to add those.
It's also not very clear how to add these icons generically: in Zed, each language has different tree-sitter queries that denote "struct", "interface", etc. entities — we do not have a good way to specify which of these entities are worth querying for implementations.