Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click the error file path to open in zed editor #23440

Closed
1 task done
jizhi0v0 opened this issue Jan 22, 2025 · 6 comments
Closed
1 task done

Click the error file path to open in zed editor #23440

jizhi0v0 opened this issue Jan 22, 2025 · 6 comments
Labels
cli Command-line interface feedback enhancement [core label] macOS Platform-specific feedback for macOS behaviors, features, design, etc terminal Feedback for terminal integration, shell commands, etc

Comments

@jizhi0v0
Copy link

Check for existing issues

  • Completed

Describe the feature

When js throws an exception, for example, next.js will give the full path of the file. Currently, zed cannot jump to the corresponding file.As shown below, but zed does not support

Could not open answer-detail-ai.tsx in the editor.
The editor process exited with an error: spawn atom ENOENT.

To set up the editor integration, add something like REACT_EDITOR=atom to the .env.local file in your project folder and restart the development server.

Zed Version and System Specs

Zed: v0.170.1 (Zed Preview)
OS: macOS 15.3.0
Memory: 36 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help present your vision of the feature

No response

@SomeoneToIgnore
Copy link
Contributor

It's quite hard to undestand what is it all about:

When js throws an exception, for example, next.js will give the full path of the file.

Is it the terminal where things are displayed?

Could not open answer-detail-ai.tsx in the editor.

Is this the error shown in the terminal which you want to click on?
What is the project structure?


For terminal, we do allow cmd-click to open files and directories that Zed can resolve, have you tried that?

@SomeoneToIgnore SomeoneToIgnore added the awaiting info Issue that needs more information from the user label Jan 22, 2025
@jizhi0v0
Copy link
Author

It's quite hard to undestand what is it all about:

When js throws an exception, for example, next.js will give the full path of the file.

Is it the terminal where things are displayed?

Could not open answer-detail-ai.tsx in the editor.

Is this the error shown in the terminal which you want to click on? What is the project structure?

For terminal, we do allow cmd-click to open files and directories that Zed can resolve, have you tried that?

Sorry I didn't express my meaning clearly. I hope to jump to the corresponding file location of zed when clicking the file path in the picture
Image

@jizhi0v0
Copy link
Author

It's quite hard to undestand what is it all about:

When js throws an exception, for example, next.js will give the full path of the file.

Is it the terminal where things are displayed?

Could not open answer-detail-ai.tsx in the editor.

Is this the error shown in the terminal which you want to click on? What is the project structure?
For terminal, we do allow cmd-click to open files and directories that Zed can resolve, have you tried that?

Sorry I didn't express my meaning clearly. I hope to jump to the corresponding file location of zed when clicking the file path in the picture Image

After i click the error file path,I see the following in the terminal

Image

@SomeoneToIgnore SomeoneToIgnore removed the awaiting info Issue that needs more information from the user label Jan 22, 2025
@SomeoneToIgnore
Copy link
Contributor

SomeoneToIgnore commented Jan 22, 2025

Ok, so there is an external app that you click at, and that app gives you a text, showing that

  1. It failed to call atom editor binary with certain arguments
  2. It proposed to do REACT_EDITOR=FOO

to the .env.local file in your project folder and restart the development server.

Have you tried to follow the advice and set REACT_EDITOR=zed, then restart the development server?
Presumably, you need to install Zed CLI first (check out Zed's menus or use cmd-shift-p in Zed to open the command prompt, input cli there and select the installation action.

@jizhi0v0
Copy link
Author

Ok, so there is an external app that you click at, and that app gives you a text, showing that

  1. It failed to call atom editor binary with certain arguments
  2. It proposed to do REACT_EDITOR=FOO

to the .env.local file in your project folder and restart the development server.

Have you tried to follow the advice and set REACT_EDITOR=zed, then restart the development server? Presumably, you need to install Zed CLI first (check out Zed's menus or use cmd-shift-p in Zed to open the command prompt, input cli there and select the installation action.

Thanks! After setting REACT_EDITOR=zed, it works, but I don't get to the specify Line:Column.

@SomeoneToIgnore
Copy link
Contributor

That part is the same as in #22990 and seems that Zed + macOS integration needs something more on top (*.plist adjustments??).

Will close this for now, as partially resolved.

@SomeoneToIgnore SomeoneToIgnore closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2025
@notpeter notpeter added terminal Feedback for terminal integration, shell commands, etc cli Command-line interface feedback macOS Platform-specific feedback for macOS behaviors, features, design, etc and removed triage labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Command-line interface feedback enhancement [core label] macOS Platform-specific feedback for macOS behaviors, features, design, etc terminal Feedback for terminal integration, shell commands, etc
Projects
None yet
Development

No branches or pull requests

3 participants