Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git_ui: Update commit composer and git status entry UI #22738

Merged
merged 7 commits into from
Jan 7, 2025

Conversation

iamnbutler
Copy link
Member

@iamnbutler iamnbutler commented Jan 6, 2025

Blocked on:

  • No way to get # of lines changed (added/removed)
  • Need methods for:
    • commit
    • stage
    • unstage
    • revert_all - Similar to Editor::RevertFile, but for all changes in the project

TODO:

  • Update checkbox visual style to match figma

  • Update panel button style to filled

  • Panel header

    • Correct 1 change suffix (1 changes -> 1 change)
    • Add lines changed badge
    • Add context menu button (...)
    • Add context menu
    • Wire up Revert All
  • Entry List

    • Revert unwanted ListItem styling
    • Add selected, hover states
    • Add scrolled_to_top, scrolled_to_bottom
    • Show gradient overflow indicator
    • Add JumpToTop, JumpToBottom actions to the list, bind to shift + arrow keys
    • Remove wrapping from keyboard movement
  • Entry

    • Style deleted entries with a strikethrough
    • ... on hover or selected
    • Add context menu
  • Composer

    • Todo...

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 6, 2025
@maxdeviant maxdeviant changed the title More git panel ui More git panel UI Jan 7, 2025
@iamnbutler iamnbutler changed the title More git panel UI git_ui: Update commit composer and git status entry UI Jan 7, 2025
@iamnbutler iamnbutler force-pushed the git-panel-nate-updates branch from b3da1c8 to 23f4241 Compare January 7, 2025 16:21
@iamnbutler iamnbutler marked this pull request as ready for review January 7, 2025 16:35
@iamnbutler iamnbutler enabled auto-merge January 7, 2025 16:36
@iamnbutler iamnbutler added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit f3e75d8 Jan 7, 2025
13 checks passed
@iamnbutler iamnbutler deleted the git-panel-nate-updates branch January 7, 2025 18:17
@xtanion
Copy link

xtanion commented Jan 16, 2025

Are we getting this feature on the next alpha or stable release?

@iamnbutler
Copy link
Member Author

Are we getting this feature on the next alpha or stable release?

Not yet, but soon! We are working away at all the rough edges and getting everything in place. Shouldn't be too long now :)

@xtanion
Copy link

xtanion commented Jan 22, 2025

Would love to see this feature, Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants