Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sapling_crypto::keys API to be more like orchard::keys #118

Open
str4d opened this issue Jan 18, 2024 · 0 comments · May be fixed by #125
Open

Refactor sapling_crypto::keys API to be more like orchard::keys #118

str4d opened this issue Jan 18, 2024 · 0 comments · May be fixed by #125
Assignees

Comments

@str4d
Copy link
Contributor

str4d commented Jan 18, 2024

The keys module types are derived from some of the earliest sapling-crypto code. They have public internals, expose boundaries that don't make sense in end-developer applications, and are generally tricky to work with.

We took our learnings from Sapling, and crafted the orchard::keys APIs more consciously and carefully. We should refactor the sapling_crypto::keys API to match it (as much as is possible given the various differences).

@str4d str4d self-assigned this Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant