Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable UTXOs spent in expired shielding transactions to be spendable #986

Closed
str4d opened this issue Sep 22, 2023 · 2 comments
Closed

Enable UTXOs spent in expired shielding transactions to be spendable #986

str4d opened this issue Sep 22, 2023 · 2 comments

Comments

@str4d
Copy link
Contributor

str4d commented Sep 22, 2023

Currently zcash_client_sqlite assumes that once a UTXO is shielded, it never needs to be spendable again. However, shielding transactions are created with an expiry height the same as any other transaction, so we need to handle this in some way.

The trickiest part is likely to be how we handle two competing chain tips where a shielding transaction is mined on one chain, and expired on the other.

Opened from #985 (comment).

@str4d
Copy link
Contributor Author

str4d commented Jun 20, 2024

The fourth commit of #1402 changes the transparent logic for balance calculation and selection to be the same as shielded. I'm not confident that we don't still have a problem here; I think we will continue to have risk here until transparent scanning is closer to shielded scanning.

@nuttycom
Copy link
Contributor

Between #1402, #1473 and #1496 we now believe this to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants