Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sent_notes table is not fully populated after a recovery from seed #936

Closed
daira opened this issue Sep 5, 2023 · 3 comments · Fixed by #908
Closed

sent_notes table is not fully populated after a recovery from seed #936

daira opened this issue Sep 5, 2023 · 3 comments · Fixed by #908
Labels
A-wallet Area: light wallet backend.

Comments

@daira
Copy link
Contributor

daira commented Sep 5, 2023

This is separated out of #899 since it is a better-understood issue, and can be reproduced by the test in #908.

When a wallet is recovered from seed and fully rescanned, the sent_notes table does not contain all of the notes that were in that table before the recovery.
@daira daira added the A-wallet Area: light wallet backend. label Sep 5, 2023
@nuttycom nuttycom added this to the Spend-before-Sync milestone Sep 5, 2023
@nuttycom
Copy link
Contributor

nuttycom commented Sep 6, 2023

This issue is being deferred until after the SDK 2.0.0 release. It's safe to defer this issue because the process of "enhancing" the compact transaction data, which is standard in the mobile wallets, fills in the missing information in the sent_notes table.

daira added a commit to daira/librustzcash that referenced this issue Sep 6, 2023
@daira
Add passing test for current behaviour of wallet restore from seed.
2998fcf 
refs zcash#936

Signed-off-by: Daira Emma Hopwood <[email protected]>
@daira daira removed this from the Spend-before-Sync milestone Sep 6, 2023
@nuttycom nuttycom added this to the SDK 2.0 Post-Release Cleanup milestone Sep 9, 2023
@daira daira mentioned this issue Sep 11, 2023
Merged
daira added a commit to daira/librustzcash that referenced this issue Sep 11, 2023
@daira
Add passing test for current behaviour of wallet restore from seed.
4d30cf7 
refs zcash#936

Signed-off-by: Daira Emma Hopwood <[email protected]>
daira added a commit to daira/librustzcash that referenced this issue Sep 11, 2023
@daira
Add passing test for current behaviour of wallet restore from seed.
9bbdb75 
refs zcash#936

Signed-off-by: Daira Emma Hopwood <[email protected]>
daira added a commit to daira/librustzcash that referenced this issue Sep 12, 2023
@daira
Add passing test for current behaviour of wallet restore from seed.
f2901e5 
refs zcash#936

Signed-off-by: Daira Emma Hopwood <[email protected]>
daira added a commit to daira/librustzcash that referenced this issue Sep 12, 2023
@daira
Add passing test for current behaviour of wallet restore from seed.
ffe3474 
refs zcash#936

Signed-off-by: Daira Emma Hopwood <[email protected]>
daira added a commit to daira/librustzcash that referenced this issue Sep 12, 2023
@daira
Add passing test for current behaviour of wallet restore from seed.
101c9c0 
refs zcash#936

Signed-off-by: Daira Emma Hopwood <[email protected]>
@nuttycom nuttycom reopened this Sep 14, 2023
@daira daira mentioned this issue Oct 30, 2023
Closed
@str4d str4d mentioned this issue Dec 5, 2023
Merged
@nuttycom
Copy link
Contributor

This may be fixed by #1306

@nuttycom
Copy link
Contributor

I believe that this has now been resolved by the combination of #1306 and #1402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-wallet Area: light wallet backend.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve wallet tests daira/librustzcash
2 participants
@nuttycom @daira