Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing to Block Again #71

Open
SpiralKipz opened this issue Sep 5, 2024 · 38 comments
Open

Failing to Block Again #71

SpiralKipz opened this issue Sep 5, 2024 · 38 comments
Assignees
Labels
bug Something isn't working fb-cmf

Comments

@SpiralKipz
Copy link

Unsure on any specifics, but the script is sadly not working and Facebook is nigh unusable due to how the feed is entirely junk. I'm running on 4.3.1 and it says there are no new updates, but even if I check every single box I'll still get posts from random pages with FB telling me to follow them as well as random "Album" updates with from pages/people I've never seen nor heard of. All of this is in the home tab. I've included a bunch of images in case I'm poorly describing what all is showing up.

image
image
image
image

@ckudera
Copy link

ckudera commented Sep 5, 2024

I have the same issue. Is there anything I can provide for debugging?

@zbluebugz zbluebugz self-assigned this Sep 5, 2024
@zbluebugz zbluebugz added the bug Something isn't working label Sep 5, 2024
@zbluebugz
Copy link
Owner

I'm not seeing any "junk" at the moment. Will have to wait a bit or switch locations.

Can you provide me the following information:

  • Region
  • Browser & version
  • Language you use in FB
  • Any other ad/content blockers you use

@zbluebugz
Copy link
Owner

And can you confirm it's just the blocking of "Follow" posts that not working? All other options are working?

@SpiralKipz
Copy link
Author

SpiralKipz commented Sep 5, 2024

For me it's North America/USA (assuming that's the region you're talking about), English, Chrome Version 128.0.6613.114, and running with uBlock Origin (tho I'll likely be jumping ship to another browser if/when Chrome stops letting uBlock work).

I'm not seeing any of the other things pop up (outside of stuff with the Follow button), but I'm also not seeing any of these except for if I enable the blocking of the reels at the top

image

@SpiralKipz
Copy link
Author

SpiralKipz commented Sep 5, 2024

Tried it in Brave and I don't think the "post hidden" elements are showing up to reflect when things are being hidden, but some stuff is definitely hidden as I can see it disappear when selecting stuff. In Brave it seems like in addition to the Follow stuff the Reels aren't being hidden no matter which options I select (all of this is under the News Feed).

image

@ckudera
Copy link

ckudera commented Sep 5, 2024

I'm not seeing any "junk" at the moment. Will have to wait a bit or switch locations.

Can you provide me the following information:

* Region

* Browser & version

* Language you use in FB

* Any other ad/content blockers you use

Region: Austria/Europe
Browser: Firefox 129.0.2
Language in FB: German
Other ad/content blockers: Adblock Plus, uBlock Origin

Thank you :)

@ckudera
Copy link

ckudera commented Sep 5, 2024

And can you confirm it's just the blocking of "Follow" posts that not working? All other options are working?

No, for me it blocks currently nothing.

Screenshot 2024-09-05 at 22-41-49 Facebook
Screenshot 2024-09-05 at 22-41-17 Facebook

@zbluebugz
Copy link
Owner

For me it's North America/USA (assuming that's the region you're talking about)

Thanks. Was able to use that region to provoke FB into filling my test account with junk posts. FB-CMF is not detection some of the junk posts.

Will do some work to resolve this issue.

I don't think the "post hidden" elements are showing up to reflect when things are being hidden

I'm aware of this issue - hidden news-feed posts are not being highlighted. Had a problem with this a few versions ago and never go around to fixing it.

Brave
If you cannot see the fb-cmf button, then it is likely not to be running (unless you told fb-cmf not to show the button).
If it is not running, then you'd need to allow the userscript-manager to run ... in the browser, goto Manage Extensions and enable "Developer Mode" (top right of page) - this applies to all recently updated chromium based browsers.

@zbluebugz
Copy link
Owner

Region: Austria/Europe
Browser: Firefox 129.0.2
Language in FB: German
Other ad/content blockers: Adblock Plus, uBlock Origin

Thanks - will use this as another test spot.

@zbluebugz
Copy link
Owner

Version 4.32.beta-02 is available for testing. Try it for a few days and let me know how you get on.

@ckudera
Copy link

ckudera commented Sep 8, 2024

Version 4.32.beta-02 is available for testing. Try it for a few days and let me know how you get on.

Thank you for the fast update. Regarding the blocking it seems to work.

Screenshot 2024-09-08 at 19-48-05 Facebook
However, I only see the info that an item was blocked once and not for other blocked elements in the rest of my feed.

Screenshot 2024-09-08 at 19-50-18 Facebook
That's my setting.

@zbluebugz
Copy link
Owner

In version 4.3x of the codestream, notifications for blocked News Feed posts have been disabled due to various issues. However, the userscript is still blocking certain posts where possible.

The feature will be re-enabled in version 5.x, which has not yet been released.

@SpiralKipz
Copy link
Author

Version 4.32.beta-02 is available for testing. Try it for a few days and let me know how you get on.

Pasted this in and scrolled for a while without seeing anything, so I'm hopeful.

@SpiralKipz
Copy link
Author

Seems to have possibly slightly broken again (on v4.32.beta 02)? Had stuff popping up again for a bit, but after a hard refresh I'm not currently seeing them pop up again so it could have been a weird issue of it not loading in fast enough or something. Haven't seen stuff pop up again since this little hiccup, however, so it could've been a one and done glitch. A part of me is wondering if they got cached or something since I was on a friend's page before clicking to the home timeline, but that seems unlikely.

image

@zbluebugz
Copy link
Owner

Seems to have possibly slightly broken again (on v4.32.beta 02)? Had stuff popping up again for a bit, but after a hard refresh I'm not currently seeing them pop up again so it could have been a weird issue of it not loading in fast enough or something. Haven't seen stuff pop up again since this little hiccup, however, so it could've been a one and done glitch. A part of me is wondering if they got cached or something since I was on a friend's page before clicking to the home timeline, but that seems unlikely.

When I update the userscript, I typically need to do a hard refresh a couple of times to ensure the updated code is fully active.

The userscript is coded to scan a post up to 21 times before it stops checking whether the post needs to be filtered. It's possible that Facebook is still modifying or updating the posts after those 21 scans, which might cause some posts to slip through.

  • If you'd like to see if increasing the scan limit helps, you can change line 2100 from scanCountMaxLoop: 21, to a higher number (keep it under 100!).
  • However, be cautious in raising this limit - it can have an impact on the performance of the userscript.

There’s also the possibility that Facebook is using an unknown or new HTML post structure, which could be causing some posts to bypass the userscript’s filters ...

@SpiralKipz
Copy link
Author

Okay yeah I'm getting Follow/Join things popping up again. I'll see if I keep seeing stuff if I raise the scanCountMaxLoop to 40 or so.

@SpiralKipz
Copy link
Author

Even at 40 I'm still getting it, but I think it's an issue when you click out of an album or another page into the home timeline. I haven't seen the issue happen if I refresh while on the home page, but I've had it happen when clicking via the home button at the top of the screen a few times now.

@SpiralKipz
Copy link
Author

Okay I think I can confirm that if you're on another page like a profile or browsing an album and then the orange/red dot appears over the home button then clicking it will not have things blocked likely due to pre-loading them in or something. The simple fix is to refresh after clicking it I guess.
image

@zbluebugz
Copy link
Owner

The v4.x codestream doesn't scan profile pages, which is why the fb-cmf button doesn't appear.

I'll review the code to check if there's anything unusual causing it to fail to resume scanning when transitioning from an "unknown" page structure to a "known" one.

The other option to restart the scanning is to click the fb-cmf button (if it appears), then click "Save" and "Close."

@Youtubepls
Copy link

Youtubepls commented Oct 12, 2024

I have to push this, because it does not block anything for a few days now. v4.32.beta 02 here but it's the same with 4.31.

Region: Germany/Europe
Browser: Firefox 131.0.2
Language in FB: German
Other ad/content blockers: uBlock Origin

clean my feeds options

eg

Edit: it seems to be a conflict with uBlock Origin. When I turn uBlock off it works.

@zbluebugz
Copy link
Owner

I have FF, fb-cmf and uBO working together. Have switched browser to use German as well.

I'd be interested to know what's your uBO setup looks like - can you post uBO's troubleshooting info?

  • Visit FB, scroll down until you see "Reels und Kurzvideos" ...
  • Click on uBO icon, then the middle icon at the bottom of uBO's popup
    image
  • Click on the bluish "Troubleshooting Information >"
    image
  • Click "Select All" and copy to here ...
    image

@Youtubepls
Copy link

uBlock Origin: 1.60.0
Firefox: 131
filterset (summary):
network: 154555
cosmetic: 130144
scriptlet: 26058
html: 2030
listset (total-discarded, last-updated):
added:
https://secure.fanboy.co.nz/fanboy-annoyance_ubo.txt: 103152-18179, 6d.15h.41m
https://ublockorigin.github.io/uAssets/filters/resource-abuse.txt: 83-0, 6d.15h.41m
default:
user-filters: 635-27, never
ublock-filters: 40475-149, 1h.50m Δ
ublock-badware: 11645-6, 1h.50m Δ
ublock-privacy: 1295-106, 1h.50m Δ
ublock-unbreak: 2545-5, 1h.50m Δ
ublock-quick-fixes: 156-8, 1h.50m Δ
easylist: 83387-210, 1h.50m Δ
easyprivacy: 53149-196, 1h.50m Δ
urlhaus-1: 25255-0, 12h.24m
plowe-0: 3539-991, 6d.15h.41m
DEU-0: 7540-38, 12h.24m
filterset (user): [array of 635 redacted]
trustedset:
added: [array of 12 redacted]
removed:
moz-extension-scheme
switchRuleset:
added: [array of 1 redacted]
hostRuleset:
added: [array of 1 redacted]
userSettings:
advancedUserEnabled: true
showIconBadge: false
hiddenSettings: [none]
supportStats:
allReadyAfter: 321 ms (selfie)
maxAssetCacheWait: 109 ms
cacheBackend: indexedDB
popupPanel:
blocked: 1
network:
facebook.com: 1
extended:
##div[role="complementary"] div:not([class]):not([id]) > span:no…
##+js(json-prune, require.0.3.0.__bbox.require.[].3.[-].__bbox.r…
##+js(json-prune, require.0.3.0.__bbox.require.[].3.1.__bbox.res…
##+js(json-prune-xhr-response, data.viewer.instream_video_ads da…

@zbluebugz
Copy link
Owner

I've made my copy of uBO to be similar to the screen-shot - cannot see anything odd.
There's the odd time that "Reels und Kurzvideos" is still shown, but tends to hide after a short time or if I press "Speichern" (Save) in the fb-cmf dialog box.

Can you try again, but with uBO's "Meine Filter" (My Filters) option disabled (i.e. do not use anything from "My filters")

@Youtubepls
Copy link

Youtubepls commented Oct 12, 2024

I disabled my filters though I have no special filters for facebook, but there are still a lot of entries that should be blocked like reels and random people's stuff. I have to press save on every single entry to make it vanish. And as soon as I did so, another entry gets loaded.

@zbluebugz
Copy link
Owner

It’s possible that one of the options in fb-cmf is causing the script to malfunction intermittently.

To troubleshoot:

  • Disable all Newsfeed options.
  • Disable all Supplementary/Information options.
  • Disable all Reels options.
  • Save your settings.
  • Re-enable each Newsfeed option one by one to identify which setting might be causing the script to stop working.

@Youtubepls
Copy link

Youtubepls commented Oct 12, 2024

I disabled every option, saved and only enabled the reels filter for example, but nope:

clean my feeds options

eg

Then I tried to figure out what the conflict with uBlock is. And yes: it seems to be a filter option named "uBlock filters - Quick Fixes" that causes the problem. After disabling this option no more other stuff is getting loaded:

ublock options

eg2

Sorry for all that german text in the screenshots, but I hope it is still comprehensible.

@zbluebugz
Copy link
Owner

No worries about the german text.

I haven't had much luck in being able reproduce the issues you're having.

You could try the beta version v5.01-14 and see if that helps. This version will only be available for a limited time, so please let me know once you've installed it.

@Youtubepls
Copy link

It works with beta v5.01.14. Even with uBlock filters - Quick Fixes activeted. Sometimes you can see the entries getting deleted one by one, but this is so quick that you can barely notice it. Thank you so far!

@zbluebugz
Copy link
Owner

Thanks for the feedback! Glad to hear it's working well for you, regardless of the uBO settings.

I’m aware of the effects of seeing posts being deleted. The cleaning engine in v5.x operates differently from the one in v4.x - it's a bit slower but more thorough. I’ll take another look at this behaviour in the near future.

If you don’t mind, could you give me some feedback on how v5.01.14 is working for you in a couple of weeks?

@zbluebugz
Copy link
Owner

Oh, there's a slight hiccup in the v5.01.14 code:

Enabling "Animierte GIFs" / "Animated GIFs" may cause the code to fail every now and then. Best to leave it off.

@tomerrr
Copy link

tomerrr commented Oct 31, 2024

i'm afraid sponsored posts are back again as of today

Region: asia/Israel
browser: Brave Version 1.71.121 Chromium: 130.0.6723.91 (shields disabled)
language: english
Tampermonkey 5.3.1 / Clean my feed 4.32 beta 2

@zbluebugz
Copy link
Owner

Current working on updating the detection rules.

@zbluebugz
Copy link
Owner

Version 5.01 has been released.

Available on GreasyFork and here (github / code).

@tomerrr
Copy link

tomerrr commented Nov 1, 2024

Version 5.01 has been released.

Available on GreasyFork and here (github / code).

thanks, i think the feed load quicker now, no sponsored posts, the new settings design is excellent
EDIT: i replied too quickly -
using latest 5.01 ver , see some sponsored posts

@zbluebugz
Copy link
Owner

Another user has reported it being a bit too aggressive - flagging some valid posts as sponsored.

Is it still blocking anything when the sponsored posts are showing up?

Is the FB language English or another one?

Will have another look.

@zbluebugz
Copy link
Owner

Version 5.02 has been released.

@tomerrr
Copy link

tomerrr commented Dec 26, 2024

they're back,
i'm on 5.02
Brave Version 1.73.104 Chromium: 131.0.6778.204 // Facebook in English

@zbluebugz
Copy link
Owner

I'm not able to fix this for a few weeks.

Temporary Work around:

  1. enable uBlock Origin.
  2. disable sponsored blocking in this userscript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fb-cmf
Projects
None yet
Development

No branches or pull requests

5 participants