-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Visualize validation profile #114
Comments
Could we have IXT's feedback on what is required by Visualize? |
Hi @tpluscode, the first set of requirements comes from For the things we keep directly inside our repo, I tried to summarize them below. Btw. the CubeRequired properties are listed below; if one's missing the application will throw an error.
Dimensions
const timeFormats = new Map<string, string>([
[ns.xsd.gYear.value, "%Y"],
[ns.xsd.gYearMonth.value, "%Y-%m"],
[ns.xsd.date.value, "%Y-%m-%d"],
[ns.xsd.dateTime.value, "%Y-%m-%dT%H:%M:%S"],
]); or timeUnit ( I think these are all the "hard requirements" related to data fetching that would make the application crash (except of Each dimension should have only one I didn't include recommendations on what "should" be included in a cube / dimension to make Visualize happy. Should I also list these properties that can be missing, but are displayed somewhere if present (e.g. creators, contact points, landing page, etc)? |
@bprusinowski can add some words on how you treat timezones? i.e.
|
@Rdataflow when it comes to this particular property, we pass such date string to a JS Other dates, coming from e.g. temporal dimension values, are formatted using https://d3js.org/d3-time-format#timeParse, taking the timezone into account. |
@bprusinowski thank you for sharing this amendment on time and timezones 👍 |
@bprusinowski can you explain more about the implicit requirements of visualize: i.e.
and it would be interesting to also share recommendations (those could lead to messages of
see also #53 |
@Rdataflow I will try to expand on the mentioned points:
I hope this is more helpful 🤞 Generally, our logic to parse things can be found below, maybe this will be easier to follow: |
@bprusinowski how many dcat:landigPage can a cube have max? cc @dbaeder |
@Rdataflow thanks for raising this point – we currently require either zero or one, non-localized string or more than one, localized strings (so we can filter them down to one entry per language) – see https://github.com/visualize-admin/visualization-tool/blob/2aa07b96db9a057281bef3cad2b7d08c49c5e1a7/app/rdf/query-cube-metadata.ts#L143-L146 |
Found an interesting edge-case: https://s.zazuko.com/3C25xc2 We have here a cube, with a dimension with 13 distinct hierarchies parallel to each other. Using Nevertheless, Visualize can't handle this case: The visualization issue can be fixed rather easily by giving each hierarchy a distinct name. Would it be possible to catch this issue in the |
@bprusinowski I started the profile for visualize in #141 I applied the rules for |
About, |
@tpluscode cool! Yes, all of them are supported, see https://github.com/visualize-admin/visualization-tool/blob/2b77e5226adbdca7c43d592d57614a4791e696e7/app/rdf/parse.ts#L98-L106 |
The text was updated successfully, but these errors were encountered: