Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot specify relative paths #5

Open
ps-bond opened this issue Jul 29, 2021 · 4 comments
Open

Cannot specify relative paths #5

ps-bond opened this issue Jul 29, 2021 · 4 comments

Comments

@ps-bond
Copy link

ps-bond commented Jul 29, 2021

Running via ssh (installed on ssh):

Specifying "uncrustify.executablePath.linux": "${workspaceFolder}/uncrustify/uncrustify" results in an error ENOENT, while
"uncrustify.executablePath.linux": "/home/user/workspace/uncrustify/uncrustify" functions as expected.

(NB the config var uncrustify.configPath.linux does appear to accept ${workspaceFolder} )

@ps-bond
Copy link
Author

ps-bond commented Jul 30, 2021

OK, I've had a look and identified what I believe is the cause of the defect:

In util.ts, the configPath entry from settings.json explicitly expands ${workspaceFolder} (et al), while the executablePath entry is just read as text.

I'll try out some changes locally then do a PR if you're OK with that.

@zachflower
Copy link
Owner

Thanks for the report @ps-bond, a pull request would be greatly appreciated!

@ps-bond
Copy link
Author

ps-bond commented Jul 30, 2021

No problem; I've made the changes, just need to test them first.

@ps-bond
Copy link
Author

ps-bond commented Aug 23, 2021

Tested & in use on my system; seems to do what I wanted it to.
Whether there's wisdom in having uncrustify as part of a dev repo is another matter...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants