Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported CSS styles #31

Open
aplicacionamedida opened this issue Jul 18, 2017 · 3 comments
Open

Imported CSS styles #31

aplicacionamedida opened this issue Jul 18, 2017 · 3 comments

Comments

@aplicacionamedida
Copy link

The code doesn't handle the @import css rule, to embed other css style inside a css style.
https://developer.mozilla.org/en/docs/Web/CSS/@import

This feature is critical to create a single html file correctly.

The equivalent webpage2html in node.js handle this case:
https://github.com/remy/inliner/blob/master/lib/css.js

It's also interesting to add the feature of minification.

@aplicacionamedida aplicacionamedida changed the title The code doesn't imported css styles Imported CSS styles Jul 18, 2017
@zTrix
Copy link
Owner

zTrix commented Jul 20, 2017

Yeah you are right, recursive css @import is important, yet hard to implement. Let me take some time to think it over.

@gitowiec
Copy link

Hi
I know that my question is out of the topic of this issue, but...
Do you know any alternative to zTrix/webpage2html and remy/inliner written in PHP?
BTW, thanks for awesome library, it just works out of the box. My need of PHP is that
I would like to implement it into Wordpress plugin

@zTrix
Copy link
Owner

zTrix commented Oct 29, 2017

@gitowiec The code and logic is not complicated, maybe a full rewrite in PHP is not that hard?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants