You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Small thing I've noticed - you are repeating the code segment that is handling the download of the files a lot. You should generally t ry to abstract these code segments into one method (and make a parameter for each thing that changes inside a code segment).
For example:
You could easily make a method for the lambda you insert into the webview downloadListener because the logic simply the same. You could also make a method that handles the loading of a webview (and make a parameter because the url changes everytime).
There are many other places in the code where you duplicated the code so I would suggest you to skim over your code and find these occurrences. Also, maybe you should change some variable names so that they conform to the naming convention that your project (or all general java projects) use and use a more understandable name: navigation_vplan2 is snake_case which doesn't fit to the other namings in this project. You might want to use navigationVPlan2 instead. Also, you should try to avoid numbers in your variable. In general, vplan2 seems to be a weird name so someone like me who doesn't know what this project aims to do should be able to directly know what role this variable has.
Have a nice day!
The text was updated successfully, but these errors were encountered:
FluentCoding
changed the title
Some Code Design suggestions
Some code design suggestions
Jan 8, 2021
Small thing I've noticed - you are repeating the code segment that is handling the download of the files a lot. You should generally t ry to abstract these code segments into one method (and make a parameter for each thing that changes inside a code segment).
For example:
You could easily make a method for the lambda you insert into the webview downloadListener because the logic simply the same. You could also make a method that handles the loading of a webview (and make a parameter because the url changes everytime).
There are many other places in the code where you duplicated the code so I would suggest you to skim over your code and find these occurrences. Also, maybe you should change some variable names so that they conform to the naming convention that your project (or all general java projects) use and use a more understandable name: navigation_vplan2 is snake_case which doesn't fit to the other namings in this project. You might want to use navigationVPlan2 instead. Also, you should try to avoid numbers in your variable. In general, vplan2 seems to be a weird name so someone like me who doesn't know what this project aims to do should be able to directly know what role this variable has.
Have a nice day!
The text was updated successfully, but these errors were encountered: