Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved MS reference from new code #5

Open
yringler opened this issue May 4, 2021 · 1 comment · Fixed by #6
Open

Improved MS reference from new code #5

yringler opened this issue May 4, 2021 · 1 comment · Fixed by #6
Assignees

Comments

@yringler
Copy link
Owner

yringler commented May 4, 2021

An interesting policy, but to each their own I suppose.

Unfortunately yes, is not open source, for now, maybe in the future they can change their mind.

Anyway, thank you for your contribution, it should be live on nuget later this week, and hopefully others will find it useful. All the best.

Cool! If you need more help I'm glad to do it.

One thing that I did in that project is to have on the project just to reference the hyperlinks
And created another project for the implementation. Just to not mix the Microsoft code with the custom one.
To have access to the internals you just need to edit the ".csproj" where you added the Microsoft hyperlinks and add:

<ItemGroup>
		<AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
			<_Parameter1>"PUT_HERE_THE_PROJECT_NAME_WHERE_YOU_WANT_TO_SEE_INTERNALS"</_Parameter1>
		</AssemblyAttribute>
	</ItemGroup>

Thanks for the help and good luck for this and future projects.

Originally posted by @joaoantunes in #3 (comment)

@yringler
Copy link
Owner Author

yringler commented Nov 3, 2021

Expose internals of DistributedResponseCachingMiddleware to DistributedResponseCachingMiddlewareTests

This issue is about the DistributedResponseCachingMiddleware csproj, that instead of adding in microsoft code via links, there should be a new csproj which only links to the MS code,
and that new csproj should expose internals to DistributedResponseCachingMiddleware
and DistributedResponseCachingMiddleware would simply use that project

That would keep the solution explorer view of DistributedResponseCachingMiddleware much cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants