From 13dff4eb4457661f92b4c21b535fa8e6c994ebe9 Mon Sep 17 00:00:00 2001
From: thorsten sideb0ard <sideboard@google.com>
Date: Tue, 7 May 2024 11:20:22 -0700
Subject: [PATCH] Correcting HasEverPlayed metric entry (#3171)

Cobalt.Media.HasEverPlayed was correctly being logged as
base::UmaHistogramBoolean()
however, it was incorrectly using an enum for PipelineStatus.

This CL adds a new enum BooleanHasPlayed and sets
Cobalt.Media.HasEverPlayed to use it.
( I used a new enum rather than just the Boolean enum to follow
Chromium's example:

https://source.chromium.org/chromium/chromium/src/+/main:tools/metrics/histograms/metadata/media/histograms.xml;l=3891)

b/337308115

(cherry picked from commit 031665ccc45be659b32454bdbf5a27f4097c2b19)
---
 tools/metrics/histograms/metadata/cobalt/enums.xml      | 5 +++++
 tools/metrics/histograms/metadata/cobalt/histograms.xml | 5 ++---
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/tools/metrics/histograms/metadata/cobalt/enums.xml b/tools/metrics/histograms/metadata/cobalt/enums.xml
index 17bce4975980..c593a7a6f734 100644
--- a/tools/metrics/histograms/metadata/cobalt/enums.xml
+++ b/tools/metrics/histograms/metadata/cobalt/enums.xml
@@ -37,6 +37,11 @@ https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histogra
   <int value="1" label="True"/>
 </enum>
 
+<enum name="BooleanHasPlayed">
+  <int value="0" label="Never played"/>
+  <int value="1" label="Played"/>
+</enum>
+
 <enum name="PipelineStatus">
   <summary>
    Possible status values reported by the Media Pipeline
diff --git a/tools/metrics/histograms/metadata/cobalt/histograms.xml b/tools/metrics/histograms/metadata/cobalt/histograms.xml
index 29323aafae69..ee2243352908 100644
--- a/tools/metrics/histograms/metadata/cobalt/histograms.xml
+++ b/tools/metrics/histograms/metadata/cobalt/histograms.xml
@@ -119,15 +119,14 @@ Always run the pretty print utility on this file after editing:
   </summary>
 </histogram>
 
-<histogram name="Cobalt.Media.HasEverPlayed" enum="PipelineStatus"
+<histogram name="Cobalt.Media.HasEverPlayed" enum="BooleanHasPlayed"
     expires_after="never">
 <!-- expires-never: Needed for baseline Media pipeline health metric. -->
 
   <owner>sideboard@google.com</owner>
   <owner>cobalt-team@google.com</owner>
   <summary>
-    Status of the media pipeline at the end of its lifecycle for audio-video
-    streams with an unknown video codec.
+    Whether a given WebMediaPlayer instance, after preload, started playback;
   </summary>
 </histogram>