Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: susd modal not displaying #683

Open
FoxTheSin opened this issue May 18, 2022 · 2 comments · May be fixed by #688
Open

fix: susd modal not displaying #683

FoxTheSin opened this issue May 18, 2022 · 2 comments · May be fixed by #688
Labels
bug Something isn't working

Comments

@FoxTheSin
Copy link

FoxTheSin commented May 18, 2022 •
edited
Loading

Describe the bug
when sUSD in wallet (and potentially other tokens?) the deposit modal (TxContainer) doesn't appear when clicking deposit button.

To Reproduce
Steps to reproduce the behavior:

  1. Go to portfolio with susd
  2. click on deposit next to susd token
  3. Scroll down to '....'
  4. See error

Expected behavior
The deposit modal should appear and token should be zappable into vault (or, if unzapable, an error message should pop up in modal that states that token can't be zap'd)

Screenshots
normal
image

susd
image

Environment Information

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
susd contract: 0x57Ab1ec28D129707052df4dF418D58a2D46d5f51
@FoxTheSin FoxTheSin added the bug Something isn't working label May 18, 2022
@FoxTheSin FoxTheSin changed the title fix: susd fix: susd modal not displaying May 18, 2022
@xgambitox
Copy link
Contributor

Yeah. First step is to determine if sUSD is supported by zapper for zapping in into vaults. If its not supported, then we should not be displaying it at all in the portfolio view, since we want to display only actionable tokens within yearn app.

@xgambitox
Copy link
Contributor

Maybe there was an sUSD vault that is now deprecated, and that is why sUSD is treated as a valid underlying token for direct deposits?

@huggingbot huggingbot linked a pull request May 19, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Filter zapable token for wallet huggingbot/yearn-finance-v3
2 participants
@xgambitox @FoxTheSin