Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command doesn't run after "Do you want to continue? [y/N]: y" #5

Open
dpaleka opened this issue Dec 25, 2022 · 3 comments
Open

Command doesn't run after "Do you want to continue? [y/N]: y" #5

dpaleka opened this issue Dec 25, 2022 · 3 comments

Comments

@dpaleka
Copy link

dpaleka commented Dec 25, 2022

On a remote machine, entering y does not execute the command. I've successfully used the tool locally.
Here is what my terminal looks like:

(base) √√ ~ % ddo echo hello world
This command will print 'hello world' to the terminal.
echo 'hello world'
Do you want to continue? [y/N]: y
(base) √√ ~ % 

I use kitty, zsh, there is a conda env activated, it's on Ubuntu 20.04, the tool was installed with pip. Not sure which additional details to provide here.

@yasyf
Copy link
Owner

yasyf commented Jan 1, 2023

Couldn't repro this, but pushed some fixes in 0.1.16—can you check if that fixed it? if not, will reopen this.

@yasyf yasyf closed this as completed Jan 1, 2023
@dpaleka
Copy link
Author

dpaleka commented Jan 9, 2023

Same behaviour in 0.1.16 as described in the issue, except of course it's now Execute this command? [Y/n].
One additional weird thing that happens: when I enter exit the first time after executing the code in the issue, nothing happens. It's like the ddo command spawns a shell or something.

@yasyf yasyf reopened this Jan 10, 2023
@yasyf
Copy link
Owner

yasyf commented Jan 10, 2023

@dpaleka it is running the command in a new shell, but its execing so it should replace the ddo process, not spawn a new one. I want to avoid needing a new shell but it requires some architectural changes. It's on my list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants