Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes instantmusic sends eof before download has finished #135

Open
NightMachinery opened this issue Apr 17, 2019 · 2 comments
Open

Comments

@NightMachinery
Copy link

To reproduce:
Use “gaston song”, then select “Mix - Beauty and the Beast - Gaston”. (For me, it’s the 17th item now.)
instantmusic then terminates as if it had downloaded the song normally (which for me means the following text):
Downloading
Fixing id3 tags
a bytes-like object is required, not 'str'
couldnt get album art

But the youtube download starts after this:
B1A11A78-F43D-43B1-86EA-12A594784A49

The problem is that I’m using instantmusic with pexpect, and the untimely eof makes pexpect think the process has finished when it has not.

@NightMachinery
Copy link
Author

I think this might be solved if we use youtube-dl directly from Python instead of using it via CLI.

@NightMachinery
Copy link
Author

I just checked, https://m.youtube.com/watch?v=VuJTqmpBnI0&list=RDVuJTqmpBnI0&start_radio=1 is a playlist. Perhaps that’s why this is failing. Youtube-dl does have an option to ignore playlists and just download the first item ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant