Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite call loop while hot updating controller #8

Open
xbill82 opened this issue Mar 14, 2016 · 2 comments
Open

Infinite call loop while hot updating controller #8

xbill82 opened this issue Mar 14, 2016 · 2 comments

Comments

@xbill82
Copy link
Contributor

xbill82 commented Mar 14, 2016

Hi, I've just set this project up with Angular HMR.

As a side note, since the example calls the global Angular variable Angular instead of angular, I had to change the angularModule regexp in angular-hmr/index.js to accept this variable name

var angularModule= /[aA]ngular[\.\n ]+module\(([\'\"\w\.\/\(\)\n\-\,\[\] ]+)\)/g;

BTW, should we address this case in another issue?

So, when I try to hot update a controller (e.g. page3Controller.js), I get no hot reload and the following error Uncaught RangeError: Maximum call stack size exceeded. The infinitely-called function is hotAddUpdateChunk.

@yargalot
Copy link
Owner

Thats odd they would change the global to Angular, is there any particular reason they did that?

@xbill82
Copy link
Contributor Author

xbill82 commented Mar 21, 2016

I don't think so. They just did it like that...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants