Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching from Makefile to CMake #4

Open
yangyushi opened this issue Dec 7, 2020 · 2 comments
Open

Switching from Makefile to CMake #4

yangyushi opened this issue Dec 7, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@yangyushi
Copy link
Owner

I hand-coded all the makefiles which may not be a good demonstration... At some point I will shift this to CMake

@yangyushi yangyushi added the enhancement New feature or request label Dec 7, 2020
@yangyushi
Copy link
Owner Author

yangyushi commented Aug 31, 2021

Experimenting around my other projects, I find some ideas.

  • add Eigen and pybind11 as submodules.
  • just include the source code of voro++ with correct building configurations

The final goal should be that the user will need to use CMake to compile all C++ code, and to use pip to install all Python packages.

@yangyushi
Copy link
Owner Author

The commits 463a8b1 and 10b180c removed the dependency on the pybind11, Eigen, and voro++.

The user will still have to use build.sh to build the package, but it should be easier now. I will work towards the goal, of using CMake for building the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant