fluxible-router: remove route from dehydrated state #670
Conversation
Besides avoiding unnecessary data to be sent to the client (given that RouteStore currently doesn't need currentNavigate.route to re-hydrate), we prevent browsers to break given that currentNavigate.route.action and currentNavigate.route.handler may contain server transpiled code that is not compatible with them.
|
Thanks for the review :). @lingyan, @redonkulus could we have a 1.x release of fluxible-router? |
|
@pablopalacios [email protected] published |
|
@pablopalacios we probably want to cherry-pick this into the 2.x branch as well |
|
@redonkulus yup yup. But I don't know which branch I should base on. fluxible router on master is outdated if compared to the branch we are using for fluxible-addons-react. Since we already released a beta version of both packages, could we merge addons branch on master and keeping moving from there? |
|
ya its a little funky right now, I'd say just cherry pick the change into the fluxible-addons-react branch we are using for now. Soon we will be able to merge that into master when we are more comfortable with the changes and migration path. |
Closes #522 (and unsolved #439)
@redonkulus we're facing the issues mentioned in the links above in my company. The summary is:
Given that:
The following problems occur:
Previously we were doing some crazy workarounds on our application and I thought it was specific to us. But after checking #522, #439 and fluxible-router codebase, I realized that we could have this fixed in the package itself.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.