-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.28.1 breaks support for space option in typescript #445
Comments
// @pvdlg |
For Typescript files we set the rule Line 285 in 2e39794
So not surer what is the problem you are reporting. Can you provide a reproductible case with your config, the file you lint and what report you get and expect? |
create a temp folder, put in a ts file, for example index.ts with this content: export function foo(): void {
console.log('bar');
} and a package.json with this content {
"name": "xo-testing",
"xo": {
"space": 2
}
} Then run these two commands: npm i [email protected] && npx xo
npm i [email protected] && npx xo Using 0.28.0 this works fine without errors. Also: In #446 I added test cases for the space option which are failing on 0.28.1 and work on 0.28.0. |
Thanks! Will look into that tonight |
So the problem is the So as a result for TS files we end up with both Fixing xojs/eslint-config-xo-typescript#23 will solve the issue |
Never mind my last comment, the |
I assume #442 overrides the options set by space.
npm i [email protected] && npx xo
works fine.npm i [email protected] && npx xo
does not.The text was updated successfully, but these errors were encountered: